Re: [PATCH] drm/gem: Document that handle_create must be the last step

2018-03-26 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 10:12:03AM +0200, Oleksandr Andrushchenko wrote: > On 03/22/2018 10:02 AM, Daniel Vetter wrote: > > It published > s/It/If Doesn't make much sense to me, It = drm_gem_handle_create. > > the gem object to userspace, by that point other threads > > can guess the id and sta

Re: [PATCH] drm/gem: Document that handle_create must be the last step

2018-03-22 Thread Oleksandr Andrushchenko
On 03/22/2018 10:02 AM, Daniel Vetter wrote: It published s/It/If the gem object to userspace, by that point other threads can guess the id and start using it. And gem IDs are _very_ easy to guess (it's just an idr). Since gem objects is the only thing we allow drivers to create themselves (

[PATCH] drm/gem: Document that handle_create must be the last step

2018-03-22 Thread Daniel Vetter
It published the gem object to userspace, by that point other threads can guess the id and start using it. And gem IDs are _very_ easy to guess (it's just an idr). Since gem objects is the only thing we allow drivers to create themselves (all the kms/prime/syncobj stuff is handled by the core) no