[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-13 Thread Meng Yi
> Subject: Re: [PATCH] drm/fsl-dcu: Add gamma set for crtc > > On Mon, Sep 05, 2016 at 12:24:32AM -0700, Stefan Agner wrote: > > > So, afaik, we deal with 3x 256 32-bit register which happen to be a > > different endianness on one SoC implementing the DCU IP... > >

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-12 Thread Mark Brown
On Mon, Sep 05, 2016 at 12:24:32AM -0700, Stefan Agner wrote: > So, afaik, we deal with 3x 256 32-bit register which happen to be a > different endianness on one SoC implementing the DCU IP... That does sound like a second regmap then. -- next part -- A non-text attachment

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-05 Thread Meng Yi
Hi Stefan, > > > > This is a errta for DCU, Gamma registers are supposed to be big > > endian, but actually it is little endian, do we > > Really need to create a second regmap? > > Do you have the exact wording of the errata? Below is the description from hardware team. Affects: 2D-ACE Descrip

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-05 Thread Meng Yi
Hi Stefan, > > + */ > > +static u32 swap_bytes(u16 var) > > We certainly don't want a byte swapping function in the driver. I am sure > Linux > has appropriate functions for that already, however, I am not convinced that > we need that at all. > Yeah, sure. Actually I had sent the V2 for this

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-05 Thread Stefan Agner
On 2016-09-03 03:49, Mark Brown wrote: > On Fri, Sep 02, 2016 at 02:22:46PM -0700, Stefan Agner wrote: >> I guess the problem is that regmap_write does byte swapping because >> ls1021a.dtsi defines the whole DCU register space to be big-endian. So >> you end up doing byte swapping twice. > >> If t

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-05 Thread Stefan Agner
On 2016-09-04 19:28, Meng Yi wrote: > Hi Stefan, > >> > + */ >> > +static u32 swap_bytes(u16 var) >> >> We certainly don't want a byte swapping function in the driver. I am sure >> Linux >> has appropriate functions for that already, however, I am not convinced that >> we need that at all. >> >

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-03 Thread Mark Brown
On Fri, Sep 02, 2016 at 02:22:46PM -0700, Stefan Agner wrote: > Hi Meng, hi Mark, > > [added Mark Brown to discuss the endian issue] Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by pe

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-09-02 Thread Stefan Agner
Hi Meng, hi Mark, [added Mark Brown to discuss the endian issue] On 2016-07-15 01:50, Meng Yi wrote: > Gamma correction is optional and can be used to adjust the color > output values to match the gamut of a particular TFT LCD panel > > Signed-off-by: Meng Yi > --- > drivers/gpu/drm/fsl-dcu/Kc

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-07-18 Thread Daniel Vetter
On Fri, Jul 15, 2016 at 04:50:53PM +0800, Meng Yi wrote: > Gamma correction is optional and can be used to adjust the color > output values to match the gamut of a particular TFT LCD panel > > Signed-off-by: Meng Yi Please use the new atomic color management properties instead. There's a functio

[PATCH] drm/fsl-dcu: Add gamma set for crtc

2016-07-15 Thread Meng Yi
Gamma correction is optional and can be used to adjust the color output values to match the gamut of a particular TFT LCD panel Signed-off-by: Meng Yi --- drivers/gpu/drm/fsl-dcu/Kconfig| 6 +++ drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 63 ++ drivers/