Re: [PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-08 Thread Noralf Trønnes
Den 07.01.2019 13.39, skrev Gerd Hoffmann: > Hi, > >> If register_framebuffer() fails during fbdev setup we will leak the >> framebuffer, the GEM buffer and the shadow buffer for defio. This is >> because drm_fb_helper_fbdev_setup() just calls drm_fb_helper_fini() on >> error not taking into a

Re: [PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-07 Thread Gerd Hoffmann
Hi, > If register_framebuffer() fails during fbdev setup we will leak the > framebuffer, the GEM buffer and the shadow buffer for defio. This is > because drm_fb_helper_fbdev_setup() just calls drm_fb_helper_fini() on > error not taking into account that register_framebuffer() can fail. > > Sin

[PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-05 Thread Noralf Trønnes
If register_framebuffer() fails during fbdev setup we will leak the framebuffer, the GEM buffer and the shadow buffer for defio. This is because drm_fb_helper_fbdev_setup() just calls drm_fb_helper_fini() on error not taking into account that register_framebuffer() can fail. Since the generic emul