[PATCH] drm/fb-helper: Add missed unlocks in setcmap_legacy()

2020-12-04 Thread Chuhong Yuan
setcmap_legacy() does not call drm_modeset_unlock_all() in some exits, add the missed unlocks with goto to fix it. Fixes: 964c60063bff ("drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths") Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/drm_fb_helper.c | 15 ++--

Re: [PATCH] drm/fb-helper: Add missed unlocks in setcmap_legacy()

2020-12-04 Thread Peter Rosin
Hi! On 2020-12-03 15:42, Chuhong Yuan wrote: > setcmap_legacy() does not call drm_modeset_unlock_all() in some exits, > add the missed unlocks with goto to fix it. > > Fixes: 964c60063bff ("drm/fb-helper: separate the fb_setcmap helper into > atomic and legacy paths") > Signed-off-by: Chuhong Yu

Re: [PATCH] drm/fb-helper: Add missed unlocks in setcmap_legacy()

2020-12-03 Thread Daniel Vetter
On Thu, Dec 3, 2020 at 5:11 PM Peter Rosin wrote: > > Hi! > > On 2020-12-03 15:42, Chuhong Yuan wrote: > > setcmap_legacy() does not call drm_modeset_unlock_all() in some exits, > > add the missed unlocks with goto to fix it. > > > > Fixes: 964c60063bff ("drm/fb-helper: separate the fb_setcmap hel