[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-20 Thread Andrzej Hajda
On 11/17/2015 05:12 PM, Daniel Vetter wrote: (...) > > Check crtc_state->enable, skip if false. That's the "is this pipeline > configured" knob. For plane/connector it's state->crtc, but with the same > role. > > I guess we could check that in the helpers, but we need to be careful to > still ca

[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 03:19:35PM +0100, Andrzej Hajda wrote: > Hi Daniel, > > On 11/17/2015 11:06 AM, Daniel Vetter wrote: > > On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: > >> On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > >>> From: Gustavo Padovan > >>>

[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Andrzej Hajda
Hi Daniel, On 11/17/2015 11:06 AM, Daniel Vetter wrote: > On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: >> On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace >>> direc

[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Daniel Vetter
On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: > On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace > > direct cross-driver call with drm mode). The whole atomic update

[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-12 Thread Thierry Reding
On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace > direct cross-driver call with drm mode). The whole atomic update > was failing if the hdmi display is not present/active. Add a test > to

[PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-12 Thread Gustavo Padovan
From: Gustavo Padovan Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace direct cross-driver call with drm mode). The whole atomic update was failing if the hdmi display is not present/active. Add a test to only run atomic_check() if the CRTC is active. Signed-off-by: Gustavo Padova