[PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, and etnaviv_gpu_init the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost -

Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
On Sun, Jun 14, 2020 at 4:48 AM Andy Shevchenko wrote: > > On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost > wrote: > > ... > > > + if (ret < 0) { > > > + pm_runtime_put(gpu->dev); > > Please, in all your patches fix this to be _put_noidle(). We wouldn't > bear

Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost wrote: ... > + if (ret < 0) { > + pm_runtime_put(gpu->dev); Please, in all your patches fix this to be _put_noidle(). We wouldn't bear the flag day of fixing these parts again. Yes, I know that *now* behaviour