Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-28 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 08:26:04PM +0100, Daniel Stone wrote: > On Wed, 26 Jun 2024 at 18:52, Daniel Vetter wrote: > > On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > > > So we are kind of stuck here between breaking one or

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-28 Thread Daniel Stone
Hi, On Fri, 28 Jun 2024 at 10:43, Tomeu Vizoso wrote: > On Wed, Jun 26, 2024 at 9:26 PM Daniel Stone wrote: > > It's not just etnaviv, it's literally every Mesa driver which works > > with decoupled render/display. So that would be etnaviv-v2, > > panfrost-v2, panthor-v2, v3d-v2, powervr-v2, ...

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-28 Thread Tomeu Vizoso
On Wed, Jun 26, 2024 at 9:26 PM Daniel Stone wrote: > > On Wed, 26 Jun 2024 at 18:52, Daniel Vetter wrote: > > On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > > > So we are kind of stuck here between breaking one or the oth

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
On Wed, 26 Jun 2024 at 18:52, Daniel Vetter wrote: > On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > > So we are kind of stuck here between breaking one or the other use- > > > case. I'm leaning heavily into the direction of j

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > Hi, > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > Mesa doesn't cope right now. Mostly because of the renderonly thing > > where we magically need to match render devices to otherwise render > > incapable KMS devices. The w

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:42:24AM +0300, Dmitry Baryshkov wrote: > On Wed, Jun 26, 2024 at 09:26:40AM GMT, Daniel Vetter wrote: > > On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > > > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > > > Oded, Dave, > > > > > > > >

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
Hi, On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > Mesa doesn't cope right now. Mostly because of the renderonly thing > where we magically need to match render devices to otherwise render > incapable KMS devices. The way this matching works is that the > renderonly code tries to open a scree

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 09:26:40AM GMT, Daniel Vetter wrote: > On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > > Oded, Dave, > > > > > > Do you have an opinion on this? > > > > > > Thanks, > > > > > > Tomeu > > Hi

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Lucas Stach
Am Mittwoch, dem 26.06.2024 um 09:28 +0200 schrieb Daniel Vetter: > On Mon, Jun 17, 2024 at 07:01:05PM +0200, Tomeu Vizoso wrote: > > Hi Lucas, > > > > Do you have any idea on how not to break userspace if we expose a render > > node? > > So if you get a new chip with an incompatible 3d block, y

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Mon, Jun 17, 2024 at 07:01:05PM +0200, Tomeu Vizoso wrote: > Hi Lucas, > > Do you have any idea on how not to break userspace if we expose a render node? So if you get a new chip with an incompatible 3d block, you already have that issue. And I hope etnaviv userspace can cope. Worst case you

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > Oded, Dave, > > > > Do you have an opinion on this? > > > > Thanks, > > > > Tomeu > Hi Tomeu, > > Sorry for not replying earlier, I was down with Covid (again...). >

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-17 Thread Tomeu Vizoso
Hi Lucas, Do you have any idea on how not to break userspace if we expose a render node? Cheers, Tomeu On Wed, Jun 12, 2024 at 4:26 PM Tomeu Vizoso wrote: > > On Mon, May 20, 2024 at 1:19 PM Daniel Stone wrote: > > > > Hi, > > > > On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > > > On Fr

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-12 Thread Tomeu Vizoso
On Mon, May 20, 2024 at 1:19 PM Daniel Stone wrote: > > Hi, > > On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > > On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > > > If we expose a render node for NPUs without ren

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Daniel Stone
Hi, On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > > If we expose a render node for NPUs without rendering capabilities, the > > > userspace stack will offer it to co

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Tomeu Vizoso
On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Hi Tomeu, > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > rendering, wh

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Tomeu Vizoso
Hi Lucas, On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Hi Tomeu, > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > re

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-10 Thread Lucas Stach
Hi Tomeu, Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > If we expose a render node for NPUs without rendering capabilities, the > userspace stack will offer it to compositors and applications for > rendering, which of course won't work. > > Userspace is probably right in not

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-09 Thread Oded Gabbay
On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > Oded, Dave, > > Do you have an opinion on this? > > Thanks, > > Tomeu Hi Tomeu, Sorry for not replying earlier, I was down with Covid (again...). To your question, I don't have an objection to what you are suggesting. My personal

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-09 Thread Tomeu Vizoso
Oded, Dave, Do you have an opinion on this? Thanks, Tomeu On Fri, Apr 26, 2024 at 8:10 AM Tomeu Vizoso wrote: > > On Thu, Apr 25, 2024 at 8:59 PM Jeffrey Hugo wrote: > > > > On 4/24/2024 12:37 AM, Tomeu Vizoso wrote: > > > If we expose a render node for NPUs without rendering capabilities, th

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Tomeu Vizoso
On Thu, Apr 25, 2024 at 8:59 PM Jeffrey Hugo wrote: > > On 4/24/2024 12:37 AM, Tomeu Vizoso wrote: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > rendering, which of course won't work. > > > > Us

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Tomeu Vizoso
On Thu, Apr 25, 2024 at 1:32 PM Christian Gmeiner wrote: > > Hi Tomeu, > > > > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > rendering, which of course won't work. > > > > Userspace is probably ri

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Jeffrey Hugo
On 4/24/2024 12:37 AM, Tomeu Vizoso wrote: If we expose a render node for NPUs without rendering capabilities, the userspace stack will offer it to compositors and applications for rendering, which of course won't work. Userspace is probably right in not questioning whether a render node might n

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Christian Gmeiner
Hi Tomeu, > > If we expose a render node for NPUs without rendering capabilities, the > userspace stack will offer it to compositors and applications for > rendering, which of course won't work. > > Userspace is probably right in not questioning whether a render node > might not be capable of supp

[PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-23 Thread Tomeu Vizoso
If we expose a render node for NPUs without rendering capabilities, the userspace stack will offer it to compositors and applications for rendering, which of course won't work. Userspace is probably right in not questioning whether a render node might not be capable of supporting rendering, so cha