RE: [PATCH] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-02 Thread Lin, Wayne
> -Original Message- > From: Lyude Paul > Sent: Tuesday, December 3, 2019 8:03 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > Subject: Re: [PATCH] drm/d

Re: [PATCH] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-02 Thread Lyude Paul
I'm, not entirely sure what this patch is trying to accomplish. I'm guessing maybe we're leaving stale VCPI allocations from the previous topology enablement and then somehow trying to use those again when allocating payloads? The patch looks correct at least. If this patch is fixing an issue, suc

[PATCH] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-01 Thread Wayne Lin
[Why] While disabling mst topology manager in drm_dp_mst_topology_mgr_set_mst(), now just reset the mgr->payloads but doesn't handle the mgr->proposed_vcpis. [How] Remove mgr->proposed_vcpis to NULL. Signed-off-by: Wayne Lin --- drivers/gpu/drm/drm_dp_mst_topology.c | 12 1 file ch