Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-13 Thread Jani Nikula
On Fri, 10 Dec 2021, Kees Cook wrote: > On Fri, Dec 10, 2021 at 12:06:20PM +0200, Jani Nikula wrote: >> Post Cursor2 was completely optional for the transmitter even before it >> was deprecated. >> >> And now we'd be adding 5 bytes extra to all link status reads. To fix >> the only user of drm_dp

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-10 Thread Kees Cook
On Fri, Dec 10, 2021 at 12:06:20PM +0200, Jani Nikula wrote: > On Thu, 09 Dec 2021, Kees Cook wrote: > > On Thu, Dec 09, 2021 at 05:20:45PM -0500, Harry Wentland wrote: > >> > >> > >> On 2021-12-09 01:23, Kees Cook wrote: > >> > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: > >> >

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Kees Cook wrote: > On Thu, Dec 09, 2021 at 05:20:45PM -0500, Harry Wentland wrote: >> >> >> On 2021-12-09 01:23, Kees Cook wrote: >> > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: >> >> On Fri, 03 Dec 2021, Kees Cook wrote: >> >>> The link_status array was n

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-09 Thread Kees Cook
On Thu, Dec 09, 2021 at 05:20:45PM -0500, Harry Wentland wrote: > > > On 2021-12-09 01:23, Kees Cook wrote: > > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: > >> On Fri, 03 Dec 2021, Kees Cook wrote: > >>> The link_status array was not large enough to read the Adjust Request > >>

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-09 Thread Harry Wentland
On 2021-12-09 01:23, Kees Cook wrote: > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: >> On Fri, 03 Dec 2021, Kees Cook wrote: >>> The link_status array was not large enough to read the Adjust Request >>> Post Cursor2 register. Adjust the size to include it. Found with a >>> -War

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-09 Thread Kees Cook
On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: > On Fri, 03 Dec 2021, Kees Cook wrote: > > The link_status array was not large enough to read the Adjust Request > > Post Cursor2 register. Adjust the size to include it. Found with a > > -Warray-bounds build: > > > > drivers/gpu/drm/dr

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-09 Thread Kees Cook
On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: > On Fri, 03 Dec 2021, Kees Cook wrote: > > The link_status array was not large enough to read the Adjust Request > > Post Cursor2 register. Adjust the size to include it. Found with a > > -Warray-bounds build: > > > > drivers/gpu/drm/dr

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-08 Thread Jani Nikula
On Fri, 03 Dec 2021, Kees Cook wrote: > The link_status array was not large enough to read the Adjust Request > Post Cursor2 register. Adjust the size to include it. Found with a > -Warray-bounds build: > > drivers/gpu/drm/drm_dp_helper.c: In function > 'drm_dp_get_adjust_request_post_cursor': >

[PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-03 Thread Kees Cook
The link_status array was not large enough to read the Adjust Request Post Cursor2 register. Adjust the size to include it. Found with a -Warray-bounds build: drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_get_adjust_request_post_cursor': drivers/gpu/drm/drm_dp_helper.c:59:27: error: array