Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-05 Thread Pekka Paalanen
On Mon, 4 Dec 2023 10:21:03 +0100 Maxime Ripard wrote: > Hi > > On Fri, Dec 01, 2023 at 06:03:48PM +0200, Pekka Paalanen wrote: > > On Fri, 1 Dec 2023 14:20:55 +0100 > > Maxime Ripard wrote: > > > > > On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: ... > > Is it really "g

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-04 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 08:09:22PM +0200, Ville Syrjälä wrote: > > When I was working on Weston atomic KMS support many years ago, I > > created a framework that emitted KMS property changes only when they > > actually needed changing. By review feedback (*), all that machinery was > > dropped in a

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-04 Thread Maxime Ripard
Hi On Fri, Dec 01, 2023 at 06:03:48PM +0200, Pekka Paalanen wrote: > On Fri, 1 Dec 2023 14:20:55 +0100 > Maxime Ripard wrote: > > > On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: > > > On Fri, 1 Dec 2023 10:25:09 +0100 > > > Maxime Ripard wrote: > > > > > > > On Fri, Dec 01,

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Ville Syrjälä
On Fri, Dec 01, 2023 at 06:16:16PM +0200, Pekka Paalanen wrote: > On Fri, 1 Dec 2023 17:00:32 +0200 > Ville Syrjälä wrote: > > > On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > > > From: Pekka Paalanen > > > > > > Specify how the atomic state is maintained between userspace and

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Pekka Paalanen
On Fri, 1 Dec 2023 17:00:32 +0200 Ville Syrjälä wrote: > On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > > From: Pekka Paalanen > > > > Specify how the atomic state is maintained between userspace and > > kernel, plus the special case for async flips. > > > > Signed-off-by: Pe

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Pekka Paalanen
On Fri, 1 Dec 2023 14:20:55 +0100 Maxime Ripard wrote: > On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: > > On Fri, 1 Dec 2023 10:25:09 +0100 > > Maxime Ripard wrote: > > > > > On Fri, Dec 01, 2023 at 11:06:16AM +0200, Pekka Paalanen wrote: > > > > On Fri, 1 Dec 2023 09:29:

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Ville Syrjälä
On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > From: Pekka Paalanen > > Specify how the atomic state is maintained between userspace and > kernel, plus the special case for async flips. > > Signed-off-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > This is a stan

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: > On Fri, 1 Dec 2023 10:25:09 +0100 > Maxime Ripard wrote: > > > On Fri, Dec 01, 2023 at 11:06:16AM +0200, Pekka Paalanen wrote: > > > On Fri, 1 Dec 2023 09:29:05 +0100 > > > Maxime Ripard wrote: > > > > > > > Hi, > > > > > > >

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Simon Ser
On Friday, December 1st, 2023 at 10:57, Pekka Paalanen wrote: > > > +An atomic commit can be flagged with DRM_MODE_ATOMIC_TEST_ONLY, which > > > means the > > > > It would be nice to link DRM_MODE_ATOMIC_TEST_ONLY to the actual docs here. > > This can be done with markup such as: > > > >

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Pekka Paalanen
On Fri, 1 Dec 2023 10:25:09 +0100 Maxime Ripard wrote: > On Fri, Dec 01, 2023 at 11:06:16AM +0200, Pekka Paalanen wrote: > > On Fri, 1 Dec 2023 09:29:05 +0100 > > Maxime Ripard wrote: > > > > > Hi, > > > > > > On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > > > > From: Pek

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Pekka Paalanen
On Fri, 01 Dec 2023 09:31:23 + Simon Ser wrote: > Thanks for writing these docs! A few comments below. > > On Thursday, November 30th, 2023 at 21:07, André Almeida > wrote: > > > +KMS atomic state > > + > > + > > +An atomic commit can change multiple KMS properties in an a

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Simon Ser
Thanks for writing these docs! A few comments below. On Thursday, November 30th, 2023 at 21:07, André Almeida wrote: > +KMS atomic state > + > + > +An atomic commit can change multiple KMS properties in an atomic fashion, > +without ever applying intermediate or partial state ch

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 11:06:16AM +0200, Pekka Paalanen wrote: > On Fri, 1 Dec 2023 09:29:05 +0100 > Maxime Ripard wrote: > > > Hi, > > > > On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > > > From: Pekka Paalanen > > > > > > Specify how the atomic state is maintained between

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Pekka Paalanen
On Fri, 1 Dec 2023 09:29:05 +0100 Maxime Ripard wrote: > Hi, > > On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > > From: Pekka Paalanen > > > > Specify how the atomic state is maintained between userspace and > > kernel, plus the special case for async flips. > > > > Signed-o

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-01 Thread Maxime Ripard
Hi, On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > From: Pekka Paalanen > > Specify how the atomic state is maintained between userspace and > kernel, plus the special case for async flips. > > Signed-off-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > This is a

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-11-30 Thread Bagas Sanjaya
On Thu, Nov 30, 2023 at 05:07:40PM -0300, André Almeida wrote: > From: Pekka Paalanen > > Specify how the atomic state is maintained between userspace and > kernel, plus the special case for async flips. > > Signed-off-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > This is a stan

[PATCH] drm/doc: Define KMS atomic state set

2023-11-30 Thread André Almeida
From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida --- This is a standalone patch from the following serie, the other patches are already merged: https: