Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Laurent Pinchart
On Thu, Nov 24, 2022 at 06:24:52PM +0100, Daniel Vetter wrote: > On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: > > On 2022-11-23 17:28, Daniel Vetter wrote: > > > This code was added in b65e64f7ccd4 ("drm/cma: Use > > > dma_mmap_writecombine() to mmap buffer"), but does not explain

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Robin Murphy
On 2022-11-24 17:24, Daniel Vetter wrote: On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: On 2022-11-23 17:28, Daniel Vetter wrote: This code was added in b65e64f7ccd4 ("drm/cma: Use dma_mmap_writecombine() to mmap buffer"), but does not explain why it's needed. It should be enti

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: > On 2022-11-23 17:28, Daniel Vetter wrote: > > This code was added in b65e64f7ccd4 ("drm/cma: Use > > dma_mmap_writecombine() to mmap buffer"), but does not explain why > > it's needed. > > > > It should be entirely unnecessary, becaus

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Robin Murphy
On 2022-11-23 17:28, Daniel Vetter wrote: This code was added in b65e64f7ccd4 ("drm/cma: Use dma_mmap_writecombine() to mmap buffer"), but does not explain why it's needed. It should be entirely unnecessary, because remap_pfn_range(), which is what the various dma_mmap functiosn are built on top

[PATCH] drm/dma-helpers: Don't change vma flags

2022-11-23 Thread Daniel Vetter
This code was added in b65e64f7ccd4 ("drm/cma: Use dma_mmap_writecombine() to mmap buffer"), but does not explain why it's needed. It should be entirely unnecessary, because remap_pfn_range(), which is what the various dma_mmap functiosn are built on top of, does already unconditionally adjust the