Re: [PATCH] drm/damage_helper: Check if damage clips has valid values

2020-12-13 Thread Souza, Jose
On Sun, 2020-12-13 at 17:22 +, Simon Ser wrote: > Can you add some drm_dbg_atomic logs when the damage is invalid, to make it > easier for user-space to understand why an atomic commit failed? sure, this is enough? will wait for a couple of more days before send another version. diff --git

Re: [PATCH] drm/damage_helper: Check if damage clips has valid values

2020-12-13 Thread Simon Ser
Can you add some drm_dbg_atomic logs when the damage is invalid, to make it easier for user-space to understand why an atomic commit failed? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-deve

[PATCH] drm/damage_helper: Check if damage clips has valid values

2020-12-13 Thread José Roberto de Souza
Userspace can set a damage clip with a negative coordinate, negative width or height or larger than the plane. This invalid values could cause issues in some HW or even worst enable security flaws. Cc: Gwan-gyeong Mun Cc: Sean Paul Cc: Fabio Estevam Cc: Deepak Rawat Cc: dri-devel@lists.freedes