[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Maarten Lankhorst
Op 06-06-16 om 18:25 schreef Emil Velikov: > On 6 June 2016 at 17:15, Maarten Lankhorst > wrote: >> Op 06-06-16 om 18:11 schreef Emil Velikov: >>> On 6 June 2016 at 17:00, Daniel Vetter wrote: On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: > Change return value to int

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Maarten Lankhorst
Op 06-06-16 om 18:17 schreef Emil Velikov: > Hi Maarten, > > On 6 June 2016 at 10:18, Maarten Lankhorst > wrote: > >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -1076,8 +1076,6 @@ static int setcolreg(struct drm_crtc *crtc, u16 red, >> u16 green, >>

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Maarten Lankhorst
Op 06-06-16 om 18:11 schreef Emil Velikov: > On 6 June 2016 at 17:00, Daniel Vetter wrote: >> On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: >>> Change return value to int to propagate errors from gamma_set, >>> and remove start parameter. Updates always use the full size, >>>

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Daniel Vetter
On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: > Change return value to int to propagate errors from gamma_set, > and remove start parameter. Updates always use the full size, > and some drivers even ignore the start parameter altogether. Commit message should explain why we su

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Emil Velikov
On 6 June 2016 at 17:15, Maarten Lankhorst wrote: > Op 06-06-16 om 18:11 schreef Emil Velikov: >> On 6 June 2016 at 17:00, Daniel Vetter wrote: >>> On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: Change return value to int to propagate errors from gamma_set, and remov

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Emil Velikov
Hi Maarten, On 6 June 2016 at 10:18, Maarten Lankhorst wrote: > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -1076,8 +1076,6 @@ static int setcolreg(struct drm_crtc *crtc, u16 red, > u16 green, > WARN_ON(fb->bits_per_pixel != 8); > > fb_hel

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Emil Velikov
On 6 June 2016 at 17:00, Daniel Vetter wrote: > On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: >> Change return value to int to propagate errors from gamma_set, >> and remove start parameter. Updates always use the full size, >> and some drivers even ignore the start parameter

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Deucher, Alexander
VMware Graphics; Ben Skeggs; Deucher, Alexander; > Thierry Reding; Koenig, Christian > Subject: Re: [PATCH] drm/core: Change declaration for gamma_set. > > On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: > > Change return value to int to propagate errors from ga

[PATCH] drm/core: Change declaration for gamma_set.

2016-06-06 Thread Maarten Lankhorst
Change return value to int to propagate errors from gamma_set, and remove start parameter. Updates always use the full size, and some drivers even ignore the start parameter altogether. Cc: Alex Deucher Cc: Christian König Cc: David Airlie Cc: Patrik Jakobsson Cc: Ben Skeggs Cc: Eric Anholt