Re: [PATCH] drm/compat: Clear bounce structures

2021-02-26 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 05:49:11PM +0100, Maxime Ripard wrote: > On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote: > > Some of them have gaps, or fields we don't clear. Native ioctl code > > does full copies plus zero-extends on size mismatch, so nothing can > > leak. But compat is mor

Re: [PATCH] drm/compat: Clear bounce structures

2021-02-25 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote: > Some of them have gaps, or fields we don't clear. Native ioctl code > does full copies plus zero-extends on size mismatch, so nothing can > leak. But compat is more hand-rolled so need to be careful. > > None of these matter for perf

[PATCH] drm/compat: Clear bounce structures

2021-02-22 Thread Daniel Vetter
Some of them have gaps, or fields we don't clear. Native ioctl code does full copies plus zero-extends on size mismatch, so nothing can leak. But compat is more hand-rolled so need to be careful. None of these matter for performance, so just memset. Also I didn't fix up the CONFIG_DRM_LEGACY or C