Re: [PATCH] drm/client: remove the exporting of drm_client_close

2019-07-09 Thread Noralf Trønnes
Den 04.07.2019 16.07, skrev Emil Velikov: > On Thu, 4 Jul 2019 at 08:27, Denis Efremov wrote: >> >> The function drm_client_close is declared as static and marked as >> EXPORT_SYMBOL. It's a bit confusing for an internal function to be >> exported. The area of visibility for such function is it

Re: [PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Denis Efremov
> > Out of curiosity: Did you use some tool to spot this? > Just regular expressions: https://github.com/evdenis/export_checking But it's not very reliable because of false positives. I think I can try to implement this kind of check as a part of modpost in addition to CONFIG_DEBUG_SECTION_MISM

Re: [PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Emil Velikov
On Thu, 4 Jul 2019 at 08:27, Denis Efremov wrote: > > The function drm_client_close is declared as static and marked as > EXPORT_SYMBOL. It's a bit confusing for an internal function to be > exported. The area of visibility for such function is its .c file > and all other modules. Other *.c files

[PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Denis Efremov
The function drm_client_close is declared as static and marked as EXPORT_SYMBOL. It's a bit confusing for an internal function to be exported. The area of visibility for such function is its .c file and all other modules. Other *.c files of the same module can't use it, despite all other modules ca