Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-28 Thread Andrey Smirnov
On Mon, Aug 26, 2019 at 10:46 PM Tomi Valkeinen wrote: > > Hi, > > On 26/08/2019 21:25, Andrey Smirnov wrote: > > Presently, the driver code artificially limits test pattern mode to a > > single pattern with fixed color selection. It being a kernel module > > parameter makes switching "test patter

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-28 Thread Andrey Smirnov
On Tue, Aug 27, 2019 at 1:06 AM Laurent Pinchart wrote: > > Hi Andrey, > > On Mon, Aug 26, 2019 at 09:24:57PM -0700, Andrey Smirnov wrote: > > On Mon, Aug 26, 2019 at 3:08 PM Laurent Pinchart wrote: > > > On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > > > > Presently, the driver

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-27 Thread Tomi Valkeinen
On 28/08/2019 01:51, Andrey Smirnov wrote: The whole point of a driver is to avoid needing detailed knowledge of the device's internals in userspace. You won't avoid needing detailed knowledge of the device's internals if you don't have a priori knowledge in the form of a agreed upon/well kno

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-27 Thread Laurent Pinchart
Hi Andrey, On Mon, Aug 26, 2019 at 09:24:57PM -0700, Andrey Smirnov wrote: > On Mon, Aug 26, 2019 at 3:08 PM Laurent Pinchart wrote: > > On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > > > Presently, the driver code artificially limits test pattern mode to a > > > single pattern

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Tomi Valkeinen
Hi, On 26/08/2019 21:25, Andrey Smirnov wrote: Presently, the driver code artificially limits test pattern mode to a single pattern with fixed color selection. It being a kernel module parameter makes switching "test patter" <-> "proper output" modes on-the-fly clunky and outright impossible if

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Andrey Smirnov
On Mon, Aug 26, 2019 at 3:08 PM Laurent Pinchart wrote: > > Hi Andrey, > > Thank you for the patch. > > On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > > Presently, the driver code artificially limits test pattern mode to a > > single pattern with fixed color selection. It being

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > Presently, the driver code artificially limits test pattern mode to a > single pattern with fixed color selection. It being a kernel module > parameter makes switching "test patter" <-> "proper o

[PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Andrey Smirnov
Presently, the driver code artificially limits test pattern mode to a single pattern with fixed color selection. It being a kernel module parameter makes switching "test patter" <-> "proper output" modes on-the-fly clunky and outright impossible if the driver is built into the kernel. To improve t