Re: [PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-09 Thread Dan Carpenter
On Sun, Jun 09, 2024 at 10:38:39PM +0300, Dmitry Baryshkov wrote: > On Sat, Jun 08, 2024 at 05:21:08PM +0300, Dan Carpenter wrote: > > Smatch complains correctly that the NULL checking isn't consistent: > > > > drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() > > error: we previou

Re: [PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-09 Thread Dmitry Baryshkov
On Sat, Jun 08, 2024 at 05:21:08PM +0300, Dan Carpenter wrote: > Smatch complains correctly that the NULL checking isn't consistent: > > drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() > error: we previously assumed 'pdata->pwr18' could be null > (see line 2569) > > Add a NU

Re: [PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-09 Thread Dmitry Baryshkov
On Sat, Jun 08, 2024 at 05:21:08PM +0300, Dan Carpenter wrote: > Smatch complains correctly that the NULL checking isn't consistent: > > drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() > error: we previously assumed 'pdata->pwr18' could be null > (see line 2569) > > Add a NU

[PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-08 Thread Dan Carpenter
Smatch complains correctly that the NULL checking isn't consistent: drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() error: we previously assumed 'pdata->pwr18' could be null (see line 2569) Add a NULL check to prevent a NULL dereference on the error path. Fixes: b5c84a9edcd