Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi, On Thu, Jun 24, 2021 at 03:51:05PM +0300, Laurent Pinchart wrote: > CC'ing Maxime Ripard. > > Maxime, is this similar to the issue we've recently discussed with the > VC4 DSI encoder ? > > On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote: > > On Thu, 24 Jun 2021 at 22:34, Jagan T

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

CC'ing Maxime Ripard. Maxime, is this similar to the issue we've recently discussed with the VC4 DSI encoder ? On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote: > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > On Wed, 3 Fe

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Jagan, On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > Hi Jonathan, > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > > Hi Jagan, > > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > >

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Jonathan, On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > Hi Jagan, > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > dw_mipi_dsi_debugfs_init(dsi); > > pm_runtime_enable(dev); > > > > +

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Jagan, On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > dw_mipi_dsi_debugfs_init(dsi); > pm_runtime_enable(dev); > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, > +

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Yannick, Thanks for testing this change. On Mon, Feb 15, 2021 at 1:39 PM yannick Fertre wrote: > > Hello Jagan, I tested your patch on the stm32mp1 board. > Unfortunately, the dsi panel does not probe well with this patch. The > problem is due to the panel which is placed in the node of the d

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Heiko, On Wed, Feb 03, 2021 at 01:05:43PM +0100, Heiko Stübner wrote: > Am Mittwoch, 3. Februar 2021, 10:13:06 CET schrieb Jagan Teki: > > Usual I2C configured DSI bridge drivers have drm_bridge_add > > in probe and mipi_dsi_attach in bridge attach functions. > > > > With, this approach the dr

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hello Jagan, I tested your patch on the stm32mp1 board. Unfortunately, the dsi panel does not probe well with this patch. The problem is due to the panel which is placed in the node of the dsi bridge (no problem with i2c devices). Regarding component bindings for stm drivers, I am currently wo

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Am Mittwoch, 3. Februar 2021, 10:13:06 CET schrieb Jagan Teki: > Usual I2C configured DSI bridge drivers have drm_bridge_add > in probe and mipi_dsi_attach in bridge attach functions. > > With, this approach the drm pipeline is unable to find the > dsi bridge in stm drm drivers since the dw-mipi-d

[PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Usual I2C configured DSI bridge drivers have drm_bridge_add in probe and mipi_dsi_attach in bridge attach functions. With, this approach the drm pipeline is unable to find the dsi bridge in stm drm drivers since the dw-mipi-dsi bridge is adding drm bridge during bridge attach operations instead of