Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-03-15 Thread Andrzej Hajda
On 14.03.2018 16:25, Fabio Estevam wrote: > Hi Laurent, > > On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart > wrote: >> Hi Fabio, >> >> Thank you for the patch. >> >> On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote: >>> From: Fabio Estevam >>> >>> The cable_plugin member never rece

Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-03-14 Thread Fabio Estevam
Hi Laurent, On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart wrote: > Hi Fabio, > > Thank you for the patch. > > On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote: >> From: Fabio Estevam >> >> The cable_plugin member never receives an assignment, so it is always >> false, which cause

Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-02-19 Thread Laurent Pinchart
Hi Fabio, Thank you for the patch. On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote: > From: Fabio Estevam > > The cable_plugin member never receives an assignment, so it is always > false, which causes hdmi_enable_overflow_interrupts() to never > be called as per the logic below: >

[PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-02-16 Thread Fabio Estevam
From: Fabio Estevam The cable_plugin member never receives an assignment, so it is always false, which causes hdmi_enable_overflow_interrupts() to never be called as per the logic below: if (hdmi->cable_plugin && hdmi->sink_is_hdmi) hdmi_enable_overflow_interrupts(hdmi);