Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-03-10 Thread Marek Szyprowski
Hi Andy, On 10.03.2020 02:10, Andy Yan wrote: > [...] > ret = analogix_dp_dt_parse_pdata(dp); >     if (ret) >     return ERR_PTR(ret); > > >     I think this is the problem I tested. Now the pdata were parse in > probe, but the plata_data->dev_type was populated in > rockchip_d

Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-03-10 Thread Andy Yan
Hi Marek: On 3/5/20 5:03 PM, Andy Yan wrote: Hi: I tested it on a rk3399 board, but the eDP was broken after this patch applied: [    0.891873] registered taskstats version 1 [    0.892243] Loading compiled-in X.509 certificates [    0.929147] rockchip-dp ff97.edp: no DP phy configure

Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-03-06 Thread Marek Szyprowski
Hi Andy On 05.03.2020 10:03, Andy Yan wrote: > > I tested it on a rk3399 board, but the eDP was broken after this patch > applied: > > > [    0.891873] registered taskstats version 1 > [    0.892243] Loading compiled-in X.509 certificates > [    0.929147] rockchip-dp ff97.edp: no DP phy confi

Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-03-06 Thread Andy Yan
Hi: I tested it on a rk3399 board, but the eDP was broken after this patch applied: [    0.891873] registered taskstats version 1 [    0.892243] Loading compiled-in X.509 certificates [    0.929147] rockchip-dp ff97.edp: no DP phy configured [    0.931676] random: fast init done [    0.9

Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-03-03 Thread Andrzej Hajda
On 02.03.2020 15:26, Marek Szyprowski wrote: > Analogix_dp driver acquires all its resources in ->bind() callback, what > is a bit against the driver component based approach, where driver > initialization is split into probe(), where all resources are gathered, and > bind(), where objects are crea

[PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-03-02 Thread Marek Szyprowski
Analogix_dp driver acquires all its resources in ->bind() callback, what is a bit against the driver component based approach, where driver initialization is split into probe(), where all resources are gathered, and bind(), where objects are created and compound driver is initialized. Extract resou