Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-25 Thread Philippe CORNU
Hi Andrzej, On 01/25/2018 12:07 PM, Andrzej Hajda wrote: > On 24.01.2018 10:51, Philippe CORNU wrote: >> Hi Brian, >> >> On 01/23/2018 10:15 PM, Brian Norris wrote: >>> Hi Philippe, >>> >>> On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: On 01/11/2018 12:16 PM, Philippe CORNU

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-25 Thread Andrzej Hajda
On 24.01.2018 10:51, Philippe CORNU wrote: > Hi Brian, > > On 01/23/2018 10:15 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >>> On 01/11/2018 12:16 PM, Philippe CORNU wrote: To be honest, I do not really like the memcpy here too

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-24 Thread Philippe CORNU
Hi Brian, On 01/23/2018 10:15 PM, Brian Norris wrote: > Hi Philippe, > > On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >> On 01/11/2018 12:16 PM, Philippe CORNU wrote: >>> To be honest, I do not really like the memcpy here too and I agree with >>> you regarding the BE issue. >>>

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-23 Thread Brian Norris
Hi Philippe, On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: > On 01/11/2018 12:16 PM, Philippe CORNU wrote: > > To be honest, I do not really like the memcpy here too and I agree with > > you regarding the BE issue. > > > > My first "stm" driver (ie. before using this "freescale

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-18 Thread Philippe CORNU
Hi Brian, On 01/11/2018 12:16 PM, Philippe CORNU wrote: > Hi Brian, > > On 01/09/2018 07:55 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >>> Hi Brian, >>> >>> And many thanks for implementing these TODOs. >> >> And thanks for adding

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-11 Thread Philippe CORNU
Hi Brian, On 01/09/2018 07:55 PM, Brian Norris wrote: > Hi Philippe, > > On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >> Hi Brian, >> >> And many thanks for implementing these TODOs. > > And thanks for adding them; it gave me a better option than just adding > yet another swit

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-09 Thread Brian Norris
Hi Philippe, On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: > Hi Brian, > > And many thanks for implementing these TODOs. And thanks for adding them; it gave me a better option than just adding yet another switch case (MIPI_DSI_GENERIC_LONG_WRITE) ;) > On 01/06/2018 01:38 AM, B

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-09 Thread Philippe CORNU
Hi Brian, And many thanks for implementing these TODOs. On 01/06/2018 01:38 AM, Brian Norris wrote: > This takes care of 2 TODOs in this driver, by using the common DSI > packet-marshalling code instead of our custom short/long write code. > This both saves us some duplicated code and gets us fre

[PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-05 Thread Brian Norris
This takes care of 2 TODOs in this driver, by using the common DSI packet-marshalling code instead of our custom short/long write code. This both saves us some duplicated code and gets us free support for command types that weren't already part of our switch block (e.g., MIPI_DSI_GENERIC_LONG_WRITE