Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Andrzej Hajda
On 09.01.2018 14:37, Laurent Pinchart wrote: > Hi Philippe, > > On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> Regarding this patch from Brian, I think it could be nice to merge it >> (1xAcked-by, 2xReviewed-by). >> >> Could you please have a l

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Laurent Pinchart
Hi Philippe, On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: > Hi Archit, Andrzej & Laurent, > > Regarding this patch from Brian, I think it could be nice to merge it > (1xAcked-by, 2xReviewed-by). > > Could you please have a look? > > Only the small "typo" in the headline needs

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Laurent Pinchart
Hi Brian, On Tuesday, 28 November 2017 20:21:23 EET Brian Norris wrote: > On Tue, Nov 28, 2017 at 02:51:46PM +0200, Laurent Pinchart wrote: > > Hi Brian, > > > > Thank you for the patch. > > > > I'd mention dw-mipi-dsi in the subject line as the directory contains the > > dw-hdmi driver as well

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Philippe CORNU
Hi Archit, Andrzej & Laurent, Regarding this patch from Brian, I think it could be nice to merge it (1xAcked-by, 2xReviewed-by). Could you please have a look? Only the small "typo" in the headline needs to be changed. Many thanks, Philippe :-) On 11/28/2017 10:34 AM, Philippe CORNU wrote: > H

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-28 Thread Brian Norris
Hi Laurent, On Tue, Nov 28, 2017 at 02:51:46PM +0200, Laurent Pinchart wrote: > Hi Brian, > > Thank you for the patch. > > I'd mention dw-mipi-dsi in the subject line as the directory contains the dw- > hdmi driver as well that this patch doesn't touch. Yep. Does it need another tag in the subj

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-28 Thread Laurent Pinchart
Hi Brian, Thank you for the patch. I'd mention dw-mipi-dsi in the subject line as the directory contains the dw- hdmi driver as well that this patch doesn't touch. On Tuesday, 28 November 2017 03:05:38 EET Brian Norris wrote: > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-28 Thread Philippe CORNU
Hi Brian, On 11/28/2017 02:05 AM, Brian Norris wrote: > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back to us for removal. And many thanks for this cleanup.

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Archit Taneja
On 11/28/2017 06:35 AM, Brian Norris wrote: Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Reviewed-by: Archit Taneja Signed-off-by:

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Matthias Kaehlcke
El Mon, Nov 27, 2017 at 05:05:38PM -0800 Brian Norris ha dit: > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back to us for removal. > > Signed-off-by: Brian

[PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 +