Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

2017-07-03 Thread Mark Cave-Ayland
On 03/07/17 09:55, Gerd Hoffmann wrote: > Hi, > >> Hopefully Gerd has experience using bochs_drm with other non-x86 >> systems >> and can comment further. > > Just pushed to drm-misc-next, fix is correct. bochs video memory is a > pci bar, and the framebuffer is stored there. > > Using sys i

Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

2017-07-03 Thread Gerd Hoffmann
Hi, > Hopefully Gerd has experience using bochs_drm with other non-x86 > systems > and can comment further. Just pushed to drm-misc-next, fix is correct. bochs video memory is a pci bar, and the framebuffer is stored there. Using sys instead of cfb is probably a leftover from cirrus, where th

Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

2017-07-03 Thread Mark Cave-Ayland
On 03/07/17 09:11, Daniel Vetter wrote: > On Sun, Jul 02, 2017 at 10:52:43PM +0100, Mark Cave-Ayland wrote: >> The current drm_fb_helper_sys helpers referenced in fb_ops assume that the >> video memory is in system RAM. This is not the case for sparc which uses >> direct >> physical memory access

Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

2017-07-03 Thread Daniel Vetter
On Sun, Jul 02, 2017 at 10:52:43PM +0100, Mark Cave-Ayland wrote: > The current drm_fb_helper_sys helpers referenced in fb_ops assume that the > video memory is in system RAM. This is not the case for sparc which uses > direct > physical memory accesses for IO memory and causes the bochs_drm modul

[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

2017-07-02 Thread Mark Cave-Ayland
The current drm_fb_helper_sys helpers referenced in fb_ops assume that the video memory is in system RAM. This is not the case for sparc which uses direct physical memory accesses for IO memory and causes the bochs_drm module to panic immediately upon startup as it tries to initialise the framebuff