Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-26 Thread Daniel Vetter
On Fri, Jun 26, 2020 at 08:25:18AM -0700, Rob Clark wrote: > On Fri, Jun 26, 2020 at 6:46 AM Daniel Vetter wrote: > > > > On Thu, Jun 25, 2020 at 09:24:38AM -0700, Rob Clark wrote: > > > On Thu, Jun 25, 2020 at 8:55 AM Daniel Vetter > > > wrote: > > > > > > > > On Thu, Jun 25, 2020 at 4:17 PM Ro

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-26 Thread Rob Clark
On Fri, Jun 26, 2020 at 6:46 AM Daniel Vetter wrote: > > On Thu, Jun 25, 2020 at 09:24:38AM -0700, Rob Clark wrote: > > On Thu, Jun 25, 2020 at 8:55 AM Daniel Vetter > > wrote: > > > > > > On Thu, Jun 25, 2020 at 4:17 PM Rob Clark wrote: > > > > > > > > On Thu, Jun 25, 2020 at 5:35 AM Daniel Ve

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-26 Thread Daniel Vetter
On Thu, Jun 25, 2020 at 09:24:38AM -0700, Rob Clark wrote: > On Thu, Jun 25, 2020 at 8:55 AM Daniel Vetter wrote: > > > > On Thu, Jun 25, 2020 at 4:17 PM Rob Clark wrote: > > > > > > On Thu, Jun 25, 2020 at 5:35 AM Daniel Vetter > > > wrote: > > > > > > > > On Thu, Jun 25, 2020 at 1:58 PM Shawn

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Rob Clark
On Thu, Jun 25, 2020 at 8:55 AM Daniel Vetter wrote: > > On Thu, Jun 25, 2020 at 4:17 PM Rob Clark wrote: > > > > On Thu, Jun 25, 2020 at 5:35 AM Daniel Vetter > > wrote: > > > > > > On Thu, Jun 25, 2020 at 1:58 PM Shawn Guo wrote: > > > > > > > > From: Shawn Guo > > > > > > > > The msm/mdp5

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Daniel Vetter
On Thu, Jun 25, 2020 at 4:17 PM Rob Clark wrote: > > On Thu, Jun 25, 2020 at 5:35 AM Daniel Vetter wrote: > > > > On Thu, Jun 25, 2020 at 1:58 PM Shawn Guo wrote: > > > > > > From: Shawn Guo > > > > > > The msm/mdp5 driver uses drm_private_obj as its global atomic state, > > > which keeps the a

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Rob Clark
On Thu, Jun 25, 2020 at 5:35 AM Daniel Vetter wrote: > > On Thu, Jun 25, 2020 at 1:58 PM Shawn Guo wrote: > > > > From: Shawn Guo > > > > The msm/mdp5 driver uses drm_private_obj as its global atomic state, > > which keeps the assignment of hwpipe to plane. With drm_private_obj > > missing from

Re: [PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Daniel Vetter
On Thu, Jun 25, 2020 at 1:58 PM Shawn Guo wrote: > > From: Shawn Guo > > The msm/mdp5 driver uses drm_private_obj as its global atomic state, > which keeps the assignment of hwpipe to plane. With drm_private_obj > missing from duplicate state call, mdp5 suspend works with no problem > only for t

[PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Shawn Guo
From: Shawn Guo The msm/mdp5 driver uses drm_private_obj as its global atomic state, which keeps the assignment of hwpipe to plane. With drm_private_obj missing from duplicate state call, mdp5 suspend works with no problem only for the very first time. Any subsequent suspend will hit the follow