Re: [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 06:32:52PM +0300, Ville Syrjälä wrote: > On Tue, Oct 17, 2017 at 05:27:14PM +0200, Daniel Vetter wrote: > > At least when they have vblank support they need to call this, or the > > vblank core will happily call into their crtc->enable_vblank callback > > even when the crtc

Re: [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Sean Paul
On Tue, Oct 17, 2017 at 01:47:36PM -0400, Sean Paul wrote: > On Tue, Oct 17, 2017 at 04:59:39PM +0200, Daniel Vetter wrote: > > At least when they have vblank support they need to call this, or the > > vblank core will happily call into their crtc->enable_vblank callback > > even when the crtc is o

Re: [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Sean Paul
On Tue, Oct 17, 2017 at 04:59:39PM +0200, Daniel Vetter wrote: > At least when they have vblank support they need to call this, or the > vblank core will happily call into their crtc->enable_vblank callback > even when the crtc is off. Which leads to a boom when the clocks are > off on most hardwar

Re: [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Ville Syrjälä
On Tue, Oct 17, 2017 at 05:27:14PM +0200, Daniel Vetter wrote: > At least when they have vblank support they need to call this, or the > vblank core will happily call into their crtc->enable_vblank callback > even when the crtc is off. Which leads to a boom when the clocks are > off on most hardwar

[PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Daniel Vetter
At least when they have vblank support they need to call this, or the vblank core will happily call into their crtc->enable_vblank callback even when the crtc is off. Which leads to a boom when the clocks are off on most hardware (besides the inevitable confusion in the book-keeping). The consiste

Re: [Intel-gfx] [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Ville Syrjälä
On Tue, Oct 17, 2017 at 04:59:39PM +0200, Daniel Vetter wrote: > At least when they have vblank support they need to call this, or the > vblank core will happily call into their crtc->enable_vblank callback > even when the crtc is off. Which leads to a boom when the clocks are > off on most hardwar

[PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-17 Thread Daniel Vetter
At least when they have vblank support they need to call this, or the vblank core will happily call into their crtc->enable_vblank callback even when the crtc is off. Which leads to a boom when the clocks are off on most hardware (besides the inevitable confusion in the book-keeping). The consiste