Re: [PATCH] drm/atomic: Handle -EDEADLK with out-fences correctly

2017-08-18 Thread Daniel Vetter
On Fri, Aug 18, 2017 at 10:13:08PM +0200, Daniel Vetter wrote: > On Fri, Aug 18, 2017 at 01:59:10PM -0300, Gustavo Padovan wrote: > > 2017-08-14 Maarten Lankhorst : > > > > > complete_crtc_signaling is freeing fence_state, but when retrying > > > num_fences and fence_state are not zero'd. This cau

Re: [PATCH] drm/atomic: Handle -EDEADLK with out-fences correctly

2017-08-18 Thread Daniel Vetter
On Fri, Aug 18, 2017 at 01:59:10PM -0300, Gustavo Padovan wrote: > 2017-08-14 Maarten Lankhorst : > > > complete_crtc_signaling is freeing fence_state, but when retrying > > num_fences and fence_state are not zero'd. This caused duplicate > > fd's in the fence_state array, followed by a BUG_ON in

Re: [PATCH] drm/atomic: Handle -EDEADLK with out-fences correctly

2017-08-18 Thread Gustavo Padovan
2017-08-14 Maarten Lankhorst : > complete_crtc_signaling is freeing fence_state, but when retrying > num_fences and fence_state are not zero'd. This caused duplicate > fd's in the fence_state array, followed by a BUG_ON in fs/file.c > because we reallocate freed memory, and installing over an exis