Patch "drm/atomic: Add the crtc to affected crtc only if uapi.enable = true" has been added to the 5.15-stable tree

2022-01-29 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/atomic: Add the crtc to affected crtc only if uapi.enable = true to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "drm/atomic: Add the crtc to affected crtc only if uapi.enable = true" has been added to the 5.16-stable tree

2022-01-29 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/atomic: Add the crtc to affected crtc only if uapi.enable = true to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-09-29 Thread Ville Syrjälä
On Thu, Apr 01, 2021 at 02:49:13PM -0700, Navare, Manasi wrote: > On Fri, Mar 26, 2021 at 06:15:22PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote: > > > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > > > > On Fri, Mar 19, 2021 at 0

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-04-01 Thread Navare, Manasi
On Fri, Mar 26, 2021 at 06:15:22PM +0200, Ville Syrjälä wrote: > On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote: > > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > > > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > > > > On Fri, Mar 19, 2021 at 1

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-26 Thread Ville Syrjälä
On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote: > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > > > On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote: > > > > On Fri, Mar 19, 2021 at 0

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-25 Thread Navare, Manasi
On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > > On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote: > > > On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote: > > > > On Fri, Mar 19, 2021 at 0

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Ville Syrjälä
On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote: > > > On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote: > > > > On Thu, Mar 18, 2021 at 0

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Navare, Manasi
On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote: > On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote: > > On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote: > > > On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote: > > > > So basically we see this

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Ville Syrjälä
On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote: > On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote: > > > So basically we see this warning only in case of bigjoiner when > > > drm_atomic_check gets call

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Navare, Manasi
On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote: > On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote: > > So basically we see this warning only in case of bigjoiner when > > drm_atomic_check gets called without setting the state->allow_modeset flag. > > Considering the c

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Ville Syrjälä
On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote: > So basically we see this warning only in case of bigjoiner when > drm_atomic_check gets called without setting the state->allow_modeset flag. Considering the code is 'WARN(!state->allow_modeset, ...' that fact should be rather obvio

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-18 Thread Navare, Manasi
So basically we see this warning only in case of bigjoiner when drm_atomic_check gets called without setting the state->allow_modeset flag. So do you think that in i915, in intel_atomic_check_bigjoiner() we should only steal the crtc when allow_modeset flag is set in state? If we add this check th

Re: [Intel-gfx] [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-17 Thread Navare, Manasi
On Tue, Mar 16, 2021 at 11:46:38PM +, Daniel Stone wrote: > On Tue, 16 Mar 2021 at 21:35, Daniel Vetter wrote: > > > On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen > > wrote: > > > On Mon, 8 Mar 2021 16:52:58 -0800 > > > "Navare, Manasi" wrote: > > > > Hmm well after the actual real commit,

Re: [Intel-gfx] [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-16 Thread Daniel Stone
On Tue, 16 Mar 2021 at 21:35, Daniel Vetter wrote: > On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen > wrote: > > On Mon, 8 Mar 2021 16:52:58 -0800 > > "Navare, Manasi" wrote: > > > Hmm well after the actual real commit, since the second crtc is stolen > > > even though it is not being used for

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-16 Thread Daniel Vetter
On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen wrote: > > On Mon, 8 Mar 2021 16:52:58 -0800 > "Navare, Manasi" wrote: > > > On Thu, Mar 04, 2021 at 10:42:23AM +0200, Pekka Paalanen wrote: > > > On Wed, 3 Mar 2021 12:44:33 -0800 > > > "Navare, Manasi" wrote: > > > > > > > On Wed, Mar 03, 2021 at

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-09 Thread Pekka Paalanen
On Mon, 8 Mar 2021 16:52:58 -0800 "Navare, Manasi" wrote: > On Thu, Mar 04, 2021 at 10:42:23AM +0200, Pekka Paalanen wrote: > > On Wed, 3 Mar 2021 12:44:33 -0800 > > "Navare, Manasi" wrote: > > > > > On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote: > > > > On Tue, 2 Mar 2021

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-08 Thread Navare, Manasi
On Thu, Mar 04, 2021 at 10:42:23AM +0200, Pekka Paalanen wrote: > On Wed, 3 Mar 2021 12:44:33 -0800 > "Navare, Manasi" wrote: > > > On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote: > > > On Tue, 2 Mar 2021 12:41:32 -0800 > > > Manasi Navare wrote: > > > > > > > In case of a mo

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-04 Thread Pekka Paalanen
On Wed, 3 Mar 2021 12:44:33 -0800 "Navare, Manasi" wrote: > On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote: > > On Tue, 2 Mar 2021 12:41:32 -0800 > > Manasi Navare wrote: > > > > > In case of a modeset where a mode gets split across mutiple CRTCs > > > in the driver specific

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-03 Thread Navare, Manasi
On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote: > On Tue, 2 Mar 2021 12:41:32 -0800 > Manasi Navare wrote: > > > In case of a modeset where a mode gets split across mutiple CRTCs > > in the driver specific implementation (bigjoiner in i915) we wrongly count > > the affected CRTCs

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-03 Thread Pekka Paalanen
On Tue, 2 Mar 2021 12:41:32 -0800 Manasi Navare wrote: > In case of a modeset where a mode gets split across mutiple CRTCs > in the driver specific implementation (bigjoiner in i915) we wrongly count > the affected CRTCs based on the drm_crtc_mask and indicate the stolen CRTC as > an affected CR

[PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-02 Thread Manasi Navare
In case of a modeset where a mode gets split across mutiple CRTCs in the driver specific implementation (bigjoiner in i915) we wrongly count the affected CRTCs based on the drm_crtc_mask and indicate the stolen CRTC as an affected CRTC in atomic_check_only(). This triggers a warning since affected