Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-11 Thread Thomas Zimmermann
Hi Am 09.08.24 um 19:06 schrieb Dan Carpenter: On Fri, Aug 09, 2024 at 04:43:51PM +0300, Jani Nikula wrote: On Fri, 09 Aug 2024, Thomas Zimmermann wrote: Hi, thanks a lot for the bugfix. Am 09.08.24 um 14:33 schrieb Dan Carpenter: The test for "Link training failed" expect the loop to exit

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 04:43:51PM +0300, Jani Nikula wrote: > On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > > Hi, > > > > thanks a lot for the bugfix. > > > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: > >> The test for "Link training failed" expect the loop to exit with "i" > >> set to zero b

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Jani Nikula
On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > Hi, > > thanks a lot for the bugfix. > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: >> The test for "Link training failed" expect the loop to exit with "i" >> set to zero but it exits when "i" is set to -1. Change this from a >> post-op to a pre-op

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Thomas Zimmermann
Hi, thanks a lot for the bugfix. Am 09.08.24 um 14:33 schrieb Dan Carpenter: The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the numb

[PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the number of iterations from 10 to 9 but probably that's okay. Fixes: 2281475168d2 ("dr