Re: (subset) [PATCH] drm/aspeed: Fix vga_pw sysfs output

2021-11-19 Thread Maxime Ripard
On Wed, 17 Nov 2021 09:01:45 +0800, Joel Stanley wrote: > Before the drm driver had support for this file there was a driver that > exposed the contents of the vga password register to userspace. It would > present the entire register instead of interpreting it. > > The drm implementation chose to

Re: [PATCH] drm/aspeed: Fix vga_pw sysfs output

2021-11-19 Thread Jeremy Kerr
Hi Joel, > Before the drm driver had support for this file there was a driver > that exposed the contents of the vga password register to userspace. > It would present the entire register instead of interpreting it. > > The drm implementation chose to mask of the lower bit, without > explaining w

Re: [PATCH] drm/aspeed: Fix vga_pw sysfs output

2021-11-18 Thread Joel Stanley
Hi David, Daniel, On Fri, 19 Nov 2021 at 06:54, Jeremy Kerr wrote: > > Hi Joel, > > > Before the drm driver had support for this file there was a driver > > that exposed the contents of the vga password register to userspace. > > It would present the entire register instead of interpreting it. >

[PATCH] drm/aspeed: Fix vga_pw sysfs output

2021-11-16 Thread Joel Stanley
Before the drm driver had support for this file there was a driver that exposed the contents of the vga password register to userspace. It would present the entire register instead of interpreting it. The drm implementation chose to mask of the lower bit, without explaining why. This breaks the ex