Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2022 at 10:00:52AM +0200, Javier Martinez Canillas wrote: > On 6/15/22 09:53, Thomas Zimmermann wrote: > > > > > > Am 15.06.22 um 09:50 schrieb Javier Martinez Canillas: > > [...] > >>> Historically, most drivers call this function very early. But for error > >>> recovery it would

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-15 Thread Javier Martinez Canillas
On 6/15/22 09:53, Thomas Zimmermann wrote: > > > Am 15.06.22 um 09:50 schrieb Javier Martinez Canillas: > [...] >>> Historically, most drivers call this function very early. But for error >>> recovery it would be better to do it as late as possible. Ideally, >>> drivers would first initialize th

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-15 Thread Thomas Zimmermann
Am 15.06.22 um 09:50 schrieb Javier Martinez Canillas: [...] Historically, most drivers call this function very early. But for error recovery it would be better to do it as late as possible. Ideally, drivers would first initialize their DRM software state, then kickout the generic driver, and

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-15 Thread Javier Martinez Canillas
On 6/15/22 09:39, Thomas Zimmermann wrote: > Hi > > Am 14.06.22 um 23:06 schrieb Robin Murphy: >> On 2022-06-14 14:48, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 14.06.22 um 15:04 schrieb Robin Murphy: The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-15 Thread Thomas Zimmermann
Hi Am 14.06.22 um 23:06 schrieb Robin Murphy: On 2022-06-14 14:48, Thomas Zimmermann wrote: Hi Am 14.06.22 um 15:04 schrieb Robin Murphy: The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time now, which works nicely as an early framebuffer. However, once the HD

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-14 Thread Robin Murphy
On 2022-06-14 14:48, Thomas Zimmermann wrote: Hi Am 14.06.22 um 15:04 schrieb Robin Murphy: The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time now, which works nicely as an early framebuffer. However, once the HDLCD driver probes and takes over the hardware, i

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-14 Thread Thomas Zimmermann
Hi Am 14.06.22 um 15:04 schrieb Robin Murphy: The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time now, which works nicely as an early framebuffer. However, once the HDLCD driver probes and takes over the hardware, it should take over the logical framebuffer as w

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-14 Thread Robin Murphy
On 2022-06-14 14:26, Javier Martinez Canillas wrote: Hello Robin, On 6/14/22 15:04, Robin Murphy wrote: The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time now, which works nicely as an early framebuffer. However, once the HDLCD driver probes and takes over the

Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-14 Thread Javier Martinez Canillas
Hello Robin, On 6/14/22 15:04, Robin Murphy wrote: > The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 > for some time now, which works nicely as an early framebuffer. However, > once the HDLCD driver probes and takes over the hardware, it should > take over the logical frame

[PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly

2022-06-14 Thread Robin Murphy
The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 for some time now, which works nicely as an early framebuffer. However, once the HDLCD driver probes and takes over the hardware, it should take over the logical framebuffer as well, otherwise the now-defunct GOP device hangs a