Re: 答复: [PATCH] drm/amdgpu: fix fence slab teardown

2016-10-24 Thread Grazvydas Ignotas
On Mon, Oct 24, 2016 at 6:35 AM, Qu, Jim wrote: > I did observed the issue when replace kernel module use DKMS, and it maybe > get error at reboot, got calltrace: > > [ 3529.525360] > = > [ 3529.525361] BUG amd_sched_fen

[PATCH] drm/amdgpu: fix fence slab teardown

2016-10-24 Thread Alex Deucher
On Sun, Oct 23, 2016 at 2:31 PM, Grazvydas Ignotas wrote: > To free fences, call_rcu() is used, which calls amdgpu_fence_free() > after a grace period. During teardown, there is no guarantee all > callbacks have finished, so amdgpu_fence_slab may be destroyed before > all fences have been freed. I

[PATCH] drm/amdgpu: fix fence slab teardown

2016-10-24 Thread Christian König
Interesting catch, patch is Reviewed-by: Christian König . Am 24.10.2016 um 04:34 schrieb zhoucm1: > Acked-by: Chunming Zhou > > On 2016年10月24日 02:31, Grazvydas Ignotas wrote: >> To free fences, call_rcu() is used, which calls amdgpu_fence_free() >> after a grace period. During teardown,

[PATCH] drm/amdgpu: fix fence slab teardown

2016-10-24 Thread zhoucm1
Acked-by: Chunming Zhou On 2016年10月24日 02:31, Grazvydas Ignotas wrote: > To free fences, call_rcu() is used, which calls amdgpu_fence_free() > after a grace period. During teardown, there is no guarantee all > callbacks have finished, so amdgpu_fence_slab may be destroyed before > all fence

答复: [PATCH] drm/amdgpu: fix fence slab teardown

2016-10-24 Thread Qu, Jim
发件人: amd-gfx 代表 zhoucm1 发送时间: 2016å¹´10月24日 10:34 收件人: Grazvydas Ignotas; dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org 主题: Re: [PATCH] drm/amdgpu: fix fence slab teardown Acked-by: Chunming Zhou On 2016å¹´10æ

[PATCH] drm/amdgpu: fix fence slab teardown

2016-10-23 Thread Grazvydas Ignotas
To free fences, call_rcu() is used, which calls amdgpu_fence_free() after a grace period. During teardown, there is no guarantee all callbacks have finished, so amdgpu_fence_slab may be destroyed before all fences have been freed. If we are lucky, this results in some slab warnings, if not, we get