[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Julia Lawall
On Fri, 15 Apr 2016, Christian König wrote: > Am 15.04.2016 um 09:15 schrieb Julia Lawall: > > Move constants to the right of binary operators. > > > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > > > Signed-off-by: Fengguang Wu > > Signed-off-by: Julia Lawall > > In gener

[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 15:20, Julia Lawall wrote: > On Fri, 15 Apr 2016, Christian König wrote: >> Am 15.04.2016 um 09:15 schrieb Julia Lawall: >> > Move constants to the right of binary operators. >> > >> > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci >> > >> > Signed-off-by: Fenggu

[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Christian König
Am 15.04.2016 um 09:15 schrieb Julia Lawall: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall In general the patch looks ok, but do we have a documented preference wh

[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Julia Lawall
Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Could be nice to put the thing being tested first. amdgpu_grph_object_id_helpers.c |4 ++-- 1 file changed, 2 insertio

[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Joe Perches
On Fri, 2016-04-15 at 16:20 +0200, Julia Lawall wrote: > On Fri, 15 Apr 2016, Christian König wrote: > > Am 15.04.2016 um 09:15 schrieb Julia Lawall: > > > Move constants to the right of binary operators. > > > > > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > > > > > Signed-o