[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-08 Thread Shawn Starr
On Tuesday, December 6, 2016 8:59:09 AM EST Christian König wrote: > Am 06.12.2016 um 02:00 schrieb Michel Dänzer: > > On 06/12/16 05:07 AM, Alex Deucher wrote: > >> Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > >> struct drm_device's ->control member is always NULL. > >> > >> I

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-06 Thread Michel Dänzer
On 06/12/16 05:07 AM, Alex Deucher wrote: > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses > ->control->debugfs_root though. This results in the following

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-06 Thread Christian König
Am 06.12.2016 um 02:00 schrieb Michel Dänzer: > On 06/12/16 05:07 AM, Alex Deucher wrote: >> Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a >> struct drm_device's ->control member is always NULL. >> >> In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses >> ->control

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-06 Thread Daniel Vetter
ilto:nicstange at gmail.com] > > > Sent: Monday, December 05, 2016 3:30 PM > > > To: Daniel Vetter > > > Cc: Deucher, Alexander; Koenig, Christian; Michel Dänzer; linux- > > > kernel at vger.kernel.org; dri-devel at lists.freedesktop.org; Nicolai > > >

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-06 Thread Mike Lothian
t; > Cc: Deucher, Alexander; Koenig, Christian; Michel Dänzer; linux- > > kernel at vger.kernel.org; dri-devel at lists.freedesktop.org; Nicolai > > Stange > > Subject: [PATCH] drm/amdgpu: don't add files at control minor debugfs > > directory > > > >

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in a NULL pointer dereference. Fix this by omitting the drm_debugfs_

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Deucher, Alexander
rg; Nicolai Stange > Subject: [PATCH] drm/amdgpu: don't add files at control minor debugfs > directory > > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONF

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Alex Deucher
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: [9.627636] BUG: unable to handle kernel N