Alex Deucher, Thanks, that's what I thought too. But this code is
uninformative, and without it is clear what this code is doing. If you
need to provide additional information on how the code works, then for
me it's better to leave a comment.
This is actually more like a bug than an explanation of
On Wed, Apr 6, 2022 at 4:00 AM Grigory Vasilyev wrote:
>
> The code is useless and doesn't change the value.
>
> (0 << GB_ADDR_CONFIG__ROW_SIZE__SHIFT) = 0
> gb_addr_config | 0 = gb_addr_config
>
> Perhaps there could be 1 instead of 0, but this does not correspond with
> the logic of the switch.
The code is useless and doesn't change the value.
(0 << GB_ADDR_CONFIG__ROW_SIZE__SHIFT) = 0
gb_addr_config | 0 = gb_addr_config
Perhaps there could be 1 instead of 0, but this does not correspond with
the logic of the switch.
Signed-off-by: Grigory Vasilyev
---
drivers/gpu/drm/amd/amdgpu/gfx_