Re: [PATCH v2] [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-09 Thread Christian König
Am 08.12.20 um 21:16 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and amdgpu_gem_object_funcs setting into single function called from both code paths. Fixes: d693de

Re: [PATCH v2] [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread kernel test robot
Hi Andrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc7 next-20201208] [cannot apply to drm/drm-next] [If yo

Re: [PATCH v2] [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Alex Deucher
On Tue, Dec 8, 2020 at 3:16 PM Andrey Grodzovsky wrote: > > For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs > was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation > and amdgpu_gem_object_funcs setting into single function called > from both code path

Re: [PATCH v2] [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Alex Deucher
On Tue, Dec 8, 2020 at 3:16 PM Andrey Grodzovsky wrote: > > For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs > was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation > and amdgpu_gem_object_funcs setting into single function called > from both code path

[PATCH v2] [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and amdgpu_gem_object_funcs setting into single function called from both code paths. Fixes: d693def4fd1c ("drm: Remove obsolete GEM and PRIME callba

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Christian König
Am 08.12.20 um 20:11 schrieb Andrey Grodzovsky: On 12/8/20 2:01 PM, Christian König wrote: Am 08.12.20 um 19:52 schrieb Andrey Grodzovsky: On 12/8/20 1:47 PM, Christian König wrote: Am 08.12.20 um 19:44 schrieb Andrey Grodzovsky: On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 1

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
On 12/8/20 2:01 PM, Christian König wrote: Am 08.12.20 um 19:52 schrieb Andrey Grodzovsky: On 12/8/20 1:47 PM, Christian König wrote: Am 08.12.20 um 19:44 schrieb Andrey Grodzovsky: On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:3

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Christian König
Am 08.12.20 um 19:52 schrieb Andrey Grodzovsky: On 12/8/20 1:47 PM, Christian König wrote: Am 08.12.20 um 19:44 schrieb Andrey Grodzovsky: On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
On 12/8/20 1:47 PM, Christian König wrote: Am 08.12.20 um 19:44 schrieb Andrey Grodzovsky: On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs importe

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Christian König
Am 08.12.20 um 19:44 schrieb Andrey Grodzovsky: On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_g

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
On 12/8/20 1:29 PM, Christian König wrote: Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_cre

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Christian König
Am 08.12.20 um 19:26 schrieb Andrey Grodzovsky: On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
On 12/8/20 12:36 PM, Christian König wrote: Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and amdgpu_gem_object_funcs setting into single functi

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Christian König
Am 08.12.20 um 18:10 schrieb Andrey Grodzovsky: For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and amdgpu_gem_object_funcs setting into single function called from both code paths. Can you outl

Re: [PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Alex Deucher
On Tue, Dec 8, 2020 at 12:10 PM Andrey Grodzovsky wrote: > > For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs > was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation > and amdgpu_gem_object_funcs setting into single function called > from both code pat

[PATCH] drm/amdgpu: Initialise drm_gem_object_funcs for imported BOs

2020-12-08 Thread Andrey Grodzovsky
For BOs imported from outside of amdgpu, setting of amdgpu_gem_object_funcs was missing in amdgpu_dma_buf_create_obj. Fix by refactoring BO creation and amdgpu_gem_object_funcs setting into single function called from both code paths. This fixes null ptr regression casued by commit d693def drm: Re