Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Mark Yacoub
On Wed, Mar 24, 2021 at 11:25 AM Daniel Stone wrote: > > Hi Mark, > > On Wed, 24 Mar 2021 at 14:58, Mark Yacoub wrote: >> >> So you mean it would make more sense to be more explicit in handling >> DRM_FORMAT_MOD_INVALID as an incoming modifier (which will, just like >> DRM_FORMAT_MOD_LINEAR, will

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Daniel Stone
Hi Mark, On Wed, 24 Mar 2021 at 14:58, Mark Yacoub wrote: > So you mean it would make more sense to be more explicit in handling > DRM_FORMAT_MOD_INVALID as an incoming modifier (which will, just like > DRM_FORMAT_MOD_LINEAR, will return true in > dm_plane_format_mod_supported)? > That's correc

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Mark Yacoub
On Wed, Mar 24, 2021 at 8:10 AM Daniel Stone wrote: > > On Wed, 24 Mar 2021 at 10:53, Bas Nieuwenhuizen > wrote: >> >> On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: >>> >>> No modifier support does not imply linear. It's generally signalled via >>> DRM_FORMAT_MOD_INVALID, which roughly

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Daniel Stone
On Wed, 24 Mar 2021 at 10:53, Bas Nieuwenhuizen wrote: > On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: > >> No modifier support does not imply linear. It's generally signalled via >> DRM_FORMAT_MOD_INVALID, which roughly means "tiling is determined by driver >> specific mechanisms". >> >

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Bas Nieuwenhuizen
On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: > On 2021-03-23 4:32 p.m., Mark Yacoub wrote: > > On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher > wrote: > >> > >> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub > wrote: > >>> > >>> From: Mark Yacoub > >>> > >>> On initializing the framebuff

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Michel Dänzer
On 2021-03-23 4:32 p.m., Mark Yacoub wrote: > On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher wrote: >> >> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: >>> >>> From: Mark Yacoub >>> >>> On initializing the framebuffer, call drm_any_plane_has_format to do a >>> check if the modifier is suppo

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-23 Thread Mark Yacoub
On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher wrote: > > On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: > > > > From: Mark Yacoub > > > > On initializing the framebuffer, call drm_any_plane_has_format to do a > > check if the modifier is supported. drm_any_plane_has_format calls > > dm_plan

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-23 Thread Bas Nieuwenhuizen
On Wed, Mar 10, 2021 at 5:14 PM Mark Yacoub wrote: > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate that the > modifier

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-23 Thread Alex Deucher
On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: > > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate that the > modifi

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-22 Thread Mark Yacoub
"friendly ping" On Wed, Mar 10, 2021 at 11:14 AM Mark Yacoub wrote: > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate t

[PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-10 Thread Mark Yacoub
From: Mark Yacoub On initializing the framebuffer, call drm_any_plane_has_format to do a check if the modifier is supported. drm_any_plane_has_format calls dm_plane_format_mod_supported which is extended to validate that the modifier is on the list of the plane's supported modifiers. The bug was