Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-18 Thread Alex Deucher
Applied. Let's see how long this one lasts :) Alex On Tue, Aug 17, 2021 at 4:23 AM Michel Dänzer wrote: > > From: Michel Dänzer > > schedule_delayed_work does not push back the work if it was already > scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms > after the first time G

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 5:19 PM, Lazar, Lijo wrote: On 8/17/2021 4:36 PM, Michel Dänzer wrote: On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 4:36 PM, Michel Dänzer wrote: On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 P

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: > > > On 8/17/2021 3:29 PM, Michel Dänzer wrote: >> On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: >>> >>> >>> On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 1:53 PM, Michel Dän

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 2:56 PM, Michel Dänzer wrote: >> On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: >>> >>> >>> On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was alre

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms a

RE: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Quan, Evan
Zhu, James ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is > disabled > > From: Michel Dänzer > > schedule_delayed_work does not push back the work if it was already > scheduled before, so amdgpu_de

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 1:53 PM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> schedule_delayed_work does not push back the work if it was already >> scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms >> after the first time GFXOFF was

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-e

[PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-enabled again during those 100 ms. This resulted

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Michel Dänzer
On 2021-08-16 6:13 a.m., Lazar, Lijo wrote: > On 8/13/2021 9:30 PM, Michel Dänzer wrote: >> On 2021-08-13 5:07 p.m., Lazar, Lijo wrote: >>> On 8/13/2021 8:10 PM, Michel Dänzer wrote: On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: > On 8/13/2021 7:04 PM, Michel Dänzer wrote: >> On 2021-08-

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Michel Dänzer
On 2021-08-16 12:20 p.m., Quan, Evan wrote: > [AMD Official Use Only] > > Hi Michel, > > The patch seems reasonable to me(especially the cancel_delayed_work_sync() > part). > However, can you explain more about the code below? > What's the race issue here exactly? > > + /* mutex_lock could

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Michel Dänzer
On 2021-08-16 9:38 a.m., Christian König wrote: > Am 13.08.21 um 12:29 schrieb Michel Dänzer: >> From: Michel Dänzer >> >> schedule_delayed_work does not push back the work if it was already >> scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms >> after the first time GFXOFF was d

RE: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Quan, Evan
Of > Michel Dänzer > Sent: Friday, August 13, 2021 6:29 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Liu, Leo ; Zhu, James ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is > disa

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Christian König
Am 13.08.21 um 12:29 schrieb Michel Dänzer: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-ena

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-15 Thread Lazar, Lijo
On 8/13/2021 9:30 PM, Michel Dänzer wrote: On 2021-08-13 5:07 p.m., Lazar, Lijo wrote: On 8/13/2021 8:10 PM, Michel Dänzer wrote: On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM, Mich

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Michel Dänzer
On 2021-08-13 5:07 p.m., Lazar, Lijo wrote: > > > On 8/13/2021 8:10 PM, Michel Dänzer wrote: >> On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: >>> On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: > On 8/13/2021 3:59 PM, Michel Dänzer wrote: >> From:

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Lazar, Lijo
On 8/13/2021 8:10 PM, Michel Dänzer wrote: On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work i

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Michel Dänzer
On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: > On 8/13/2021 7:04 PM, Michel Dänzer wrote: >> On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: >>> On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already schedul

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Lazar, Lijo
On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms af

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Michel Dänzer
On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: > > > On 8/13/2021 3:59 PM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> schedule_delayed_work does not push back the work if it was already >> scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms >> after the first time GFXOFF was

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Lazar, Lijo
On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-e

[PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-13 Thread Michel Dänzer
From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-enabled again during those 100 ms. This resulted