Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-08-19 Thread Alex Deucher
On Wed, Aug 19, 2020 at 5:08 AM Michel Dänzer wrote: > > On 2020-07-22 7:12 p.m., Alex Deucher wrote: > > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: > >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > On Wed, Jul 22, 2020

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-08-19 Thread Michel Dänzer
On 2020-07-22 7:12 p.m., Alex Deucher wrote: > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote: On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > > From: Michel Dänzer

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Alex Deucher
On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: > > On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > >>> > >>> From: Michel Dänzer > >>> > >>> drm_atomic_crtc_check enforces th

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 4:25 PM Michel Dänzer wrote: > > On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > >>> > >>> From: Michel Dänzer > >>> > >>> drm_atomic_crtc_check enforces tha

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Michel Dänzer
On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: >>> >>> From: Michel Dänzer >>> >>> drm_atomic_crtc_check enforces that ::active can only be true if >>> ::enable is as well. >>> >>> Signed

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Kazlauskas, Nicholas
On 2020-07-22 8:51 a.m., Daniel Vetter wrote: On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: From: Michel Dänzer drm_atomic_crtc_check enforces that ::active can only be true if ::enable is as well. Signed-off-by: Michel Dänzer Looks fine to me. The check is sufficiently old enough

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > > From: Michel Dänzer > > drm_atomic_crtc_check enforces that ::active can only be true if > ::enable is as well. > > Signed-off-by: Michel Dänzer modeset vs modereset is a bit an inglorious name choice ... since this seems to be glue code

[PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Michel Dänzer
From: Michel Dänzer drm_atomic_crtc_check enforces that ::active can only be true if ::enable is as well. Signed-off-by: Michel Dänzer --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/