Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-04-26 Thread Mario Limonciello
On 4/13/2024 03:51, Gergo Koteles wrote: Hi> ABM will reduce the backlight and compensate by adjusting brightness and contrast of the image. It has 5 levels: 0, 1, 2, 3, 4. 0 means off. 4 means maximum backlight reduction. IMO, 1 and 2 look okay. 3 and 4 can be quite impactful, both to power

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-04-13 Thread Gergo Koteles
Hi> > ABM will reduce the backlight and compensate by adjusting brightness and > contrast of the image. It has 5 levels: 0, 1, 2, 3, 4. 0 means off. 4 means > maximum backlight reduction. IMO, 1 and 2 look okay. 3 and 4 can be quite > impactful, both to power and visual fidelity. I tried this

RE: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-20 Thread Deucher, Alexander
, Hamza ; > Li, Sun peng (Leo) > Subject: Re: [PATCH] drm/amd: Only allow one entity to control ABM > > Am 19.02.24 um 16:28 schrieb Alex Deucher: > > On Mon, Feb 19, 2024 at 10:19 AM Christian König > > wrote: > >> Am 16.02.24 um 19:37 schrieb Alex Deuche

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-20 Thread Christian König
Am 19.02.24 um 16:28 schrieb Alex Deucher: On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: Am 16.02.24 um 19:37 schrieb Alex Deucher: On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Alex Deucher
On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: > > Am 16.02.24 um 19:37 schrieb Alex Deucher: > > On Fri, Feb 16, 2024 at 10:42 AM Christian König > > wrote: > >> Am 16.02.24 um 16:12 schrieb Mario Limonciello: > >>> On 2/16/2024 09:05, Harry Wentland wrote: > > On 2024-02-16 0

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Christian König
Am 16.02.24 um 19:37 schrieb Alex Deucher: On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Alex Deucher
On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: > > Am 16.02.24 um 16:12 schrieb Mario Limonciello: > > On 2/16/2024 09:05, Harry Wentland wrote: > >> > >> > >> On 2024-02-16 09:47, Christian König wrote: > >>> Am 16.02.24 um 15:42 schrieb Mario Limonciello: > On 2/16/2024 08:38, Chri

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:41, Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 s

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and softwa

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Harry Wentland
On 2024-02-16 09:47, Christian König wrote: > Am 16.02.24 um 15:42 schrieb Mario Limonciello: >> On 2/16/2024 08:38, Christian König wrote: >>> Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs fil

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like power-

[PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like power-profiles-daemon) 0-4: User via command line Also