Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread José Pekkarinen
On 2023-11-07 20:03, Guenter Roeck wrote: On 11/7/23 09:26, José Pekkarinen wrote: On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread Guenter Roeck
On 11/7/23 09:26, José Pekkarinen wrote: On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread José Pekkarinen
On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative will always return false. This patch wil

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread Guenter Roeck
On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative will always return false. This patch will remove them, as well as the never reached c

[PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread José Pekkarinen
There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative will always return false. This patch will remove them, as well as the never reached code. drivers/gpu/drm/amd/pm/amdgpu_pm.c:28