Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Christian König
Well if you are bored we quite often have the problem of unused fields in structures. If your robot could find fields which are never read, that would be quite helpful I think. There probably will be a lot of false positives for things like padding, but maybe that yields something. Christi

Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Jiabing Wan
>Is your robot public available? Sorry, I started to write the robot just one week ago. It is not strong and complete enough so it is not public available now. But I am still working on it. If complete, it can be public available. In fact, this patch is catched by the script called checkinclude

Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Rodrigo Siqueira
Is your robot public available? btw, applied to amd-staging-drm-next. Thanks On 04/29, Jiabing Wan wrote: > > >Nice catch! > > > >Are you using any tool to identify this problem? > > Yes, I have a robot including many detecting scripts :) > > >Reviewed-by: Rodrigo Siqueira > > > >On 04/29,

Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Jiabing Wan
>Nice catch! > >Are you using any tool to identify this problem? Yes, I have a robot including many detecting scripts :) >Reviewed-by: Rodrigo Siqueira > >On 04/29, Wan Jiabing wrote: >> In commit 482812d56698e ("drm/amd/display: Set max TTU on >> DPG enable"), "hubp.h" was added which caused

Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Rodrigo Siqueira
Nice catch! Are you using any tool to identify this problem? Reviewed-by: Rodrigo Siqueira On 04/29, Wan Jiabing wrote: > In commit 482812d56698e ("drm/amd/display: Set max TTU on > DPG enable"), "hubp.h" was added which caused the duplicate include. > To be on the safe side, remove the later d

[PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-28 Thread Wan Jiabing
In commit 482812d56698e ("drm/amd/display: Set max TTU on DPG enable"), "hubp.h" was added which caused the duplicate include. To be on the safe side, remove the later duplicate include. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - 1 file changed, 1 deletion(-)