Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 7:51 PM Ilia Mirkin wrote: > On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner > wrote: > > I'm less sure about nouveau. It uses modifiers, but has atomic support > > only on nv50+ and that atomic support is off by default -- needs a > > nouveau.nouveau_atomic=1 boot parameter

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Ilia Mirkin
On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner wrote: > I'm less sure about nouveau. It uses modifiers, but has atomic support > only on nv50+ and that atomic support is off by default -- needs a > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to > enable modifier support uncondi

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 4:49 PM Bas Nieuwenhuizen wrote: > > On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner > wrote: > > > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > > wrote: > > > > > > I think the problem here is that application A can set the FB and then > > > application B can use ge

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > wrote: > > > > I think the problem here is that application A can set the FB and then > > application B can use getfb2 (say ffmpeg). > > > Yes. That, and also the check for 'X' won't get us

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen wrote: > > I think the problem here is that application A can set the FB and then > application B can use getfb2 (say ffmpeg). Yes. That, and also the check for 'X' won't get us far, because if i use my own software Psychtoolbox under Vulkan in di

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
I think the problem here is that application A can set the FB and then application B can use getfb2 (say ffmpeg). https://lists.freedesktop.org/archives/dri-devel/2021-January/292761.html would be my alternative patch. (I'm not good at detecting the effects of tearing apparently but tested this

[PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2020-12-31 Thread Mario Kleiner
Commit 816853f9dc4057b6c7ee3c45ca9bd5905 ("drm/amd/display: Set new format info for converted metadata.") may fix the getfb2 ioctl, but in exchange it completely breaks all pageflipping for classic user space, e.g., XOrg, as tested with both amdgpu-ddx and modesetting-ddx. This leads to massive tea