Re: [PATCH] drm/amd/display/dc: Remove dc code repetition

2024-07-04 Thread Rodrigo Siqueira Jordao
Hi Joao, First of all, thanks for your patch. Follows some of my comments: > On 6/13/24 10:05 AM, Joao Paulo Pereira da Silva wrote: You can drop the dc part in the commit title. Also, the title should highlight that you are decoupling one part of the code in a single place to avoid duplicati

[PATCH] drm/amd/display/dc: Remove dc code repetition

2024-06-13 Thread Joao Paulo Pereira da Silva
Code is repeated in functions optc1_enable_crtc (dc/optc/dcn10/dcn10_optc.c) and optc2_enable_crtc (dc/optc/dcn20/dcn20_optc.c). So, remove it with the creation of a macro. Signed-off-by: Joao Paulo Pereira da Silva --- .../amd/display/dc/optc/dcn10/dcn10_optc.c| 29 ++- ...