Re: [Linaro-mm-sig] Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:10 schrieb Greg KH: On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: Am 10.05.22 um 13:00 schrieb Greg KH: On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) t

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:16 schrieb Charan Teja Kalla: Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: And what's to keep the seconds field from also being the same? Well exporting two DMA-bufs with the same ino in the same nanosecond should be basically impossible, but

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: > >> And what's to keep the seconds field from also being the same? > > Well exporting two DMA-bufs with the same ino in the same nanosecond > should be basically impossible, but I would rather opt for using a 64bit >

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Greg KH
On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: > Am 10.05.22 um 13:00 schrieb Greg KH: > > On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: > > > The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> > > > alloc_anon_inode()) to get an inode number and

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
Thanks Greg for the inputs!! On 5/10/2022 4:30 PM, Greg KH wrote: >> The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> >> alloc_anon_inode()) to get an inode number and uses the same as a >> directory name under /sys/kernel/dmabuf/buffers/. This directory is >> used to collect the d

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 13:00 schrieb Greg KH: On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This direc

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Greg KH
On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: > The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> > alloc_anon_inode()) to get an inode number and uses the same as a > directory name under /sys/kernel/dmabuf/buffers/. This directory is > used to collect the dmabu

[PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current, failur