Re: [PATCH] clk: base: fix an incorrect NULL check on list iterator

2022-04-04 Thread Lyude Paul
This should probably be prefixed with the title "drm/nouveau/clk:", but I can fix that before pushing it. Reviewed-by: Lyude Paul Will push it to the appropriate repository shortly On Sun, 2022-03-27 at 15:58 +0800, Xiaomeng Tong wrote: > The bug is here: > if (nvkm_cstate_valid(clk, c

[PATCH] clk: base: fix an incorrect NULL check on list iterator

2022-03-27 Thread Xiaomeng Tong
The bug is here: if (nvkm_cstate_valid(clk, cstate, max_volt, clk->temp)) return cstate; The list iterator value 'cstate' will *always* be set and non-NULL by list_for_each_entry_from_reverse(), so it is incorrect to assume that the iterator value will be unchanged if the l