Re: [PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-16 Thread Daniel Thompson
On Fri, Nov 09, 2018 at 10:48:57AM +0100, Heiko Stuebner wrote: > Commit e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") > removed the driver internal enabled tracking in favor of simply checking > the pwm state. > > This can lead to issues as all of gpio-, regulator- and pwm-

Re: [PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-14 Thread Thierry Reding
On Fri, Nov 09, 2018 at 10:48:57AM +0100, Heiko Stuebner wrote: > Commit e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") > removed the driver internal enabled tracking in favor of simply checking > the pwm state. > > This can lead to issues as all of gpio-, regulator- and pwm-

Re: [PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-14 Thread Uwe Kleine-König
Hello Heiko, On Fri, Nov 09, 2018 at 10:48:57AM +0100, Heiko Stuebner wrote: > Commit e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") > removed the driver internal enabled tracking in favor of simply checking > the pwm state. > > This can lead to issues as all of gpio-, regul

Re: [PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-11 Thread Enric Balletbo i Serra
Hi Heiko, Many thanks to catch and dig into this, I did more tests but I was not able to reproduce the issue with my nfs environment. Anyway the patch looks good to me and fixes the issue for you, so On 9/11/18 10:48, Heiko Stuebner wrote: > Commit e6bcca0890b9 ("backlight: pwm_bl: Switch to usin

[PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-09 Thread Heiko Stuebner
Commit e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") removed the driver internal enabled tracking in favor of simply checking the pwm state. This can lead to issues as all of gpio-, regulator- and pwm-state are used to determine the initial state and the bootloader or kernel