Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-07-06 Thread Paul Cercueil
Le mar. 25 juin 2019 à 5:47, Thierry Reding a écrit : On Mon, Jun 24, 2019 at 04:31:57PM +0200, Paul Cercueil wrote: Le lun. 24 juin 2019 à 13:28, Daniel Thompson a écrit : > On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > > On Fri, Jun 21, 2019 at 01:41:45PM +01

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-26 Thread Uwe Kleine-König
On Wed, Jun 26, 2019 at 11:58:44AM +0200, Thierry Reding wrote: > On Wed, Jun 26, 2019 at 10:58:27AM +0200, Uwe Kleine-König wrote: > > On Tue, Jun 25, 2019 at 11:38:39AM +0200, Thierry Reding wrote: > > > On Mon, Jun 24, 2019 at 12:28:44PM +0100, Daniel Thompson wrote: > > > > [...] although given

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-26 Thread Thierry Reding
On Wed, Jun 26, 2019 at 10:58:27AM +0200, Uwe Kleine-König wrote: > On Tue, Jun 25, 2019 at 11:38:39AM +0200, Thierry Reding wrote: > > On Mon, Jun 24, 2019 at 12:28:44PM +0100, Daniel Thompson wrote: > > > [...] although given pwm-backlight is essentially a wrapper driver > > > round a PWM I wonde

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-26 Thread Uwe Kleine-König
On Tue, Jun 25, 2019 at 11:38:39AM +0200, Thierry Reding wrote: > On Mon, Jun 24, 2019 at 12:28:44PM +0100, Daniel Thompson wrote: > > [...] although given pwm-backlight is essentially a wrapper driver > > round a PWM I wondered why the pinctrl was on the backlight node > > (rather than the PWM nod

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-25 Thread Uwe Kleine-König
On Tue, Jun 25, 2019 at 11:58:21AM +0200, Thierry Reding wrote: > On Tue, Jun 25, 2019 at 09:42:20AM +0200, Uwe Kleine-König wrote: > > On Wed, May 22, 2019 at 06:34:28PM +0200, Paul Cercueil wrote: > > > When the driver probes, the PWM pin is automatically configured to its > > > default state, wh

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-25 Thread Thierry Reding
On Tue, Jun 25, 2019 at 09:42:20AM +0200, Uwe Kleine-König wrote: > On Wed, May 22, 2019 at 06:34:28PM +0200, Paul Cercueil wrote: > > When the driver probes, the PWM pin is automatically configured to its > > default state, which should be the "pwm" function. However, at this > > point we don't kn

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-25 Thread Thierry Reding
On Mon, Jun 24, 2019 at 04:31:57PM +0200, Paul Cercueil wrote: > > > Le lun. 24 juin 2019 à 13:28, Daniel Thompson a > écrit : > > On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > > > On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > > > > On 22/05/2019 17:34,

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-25 Thread Thierry Reding
On Mon, Jun 24, 2019 at 12:28:44PM +0100, Daniel Thompson wrote: > On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > > On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > > > On 22/05/2019 17:34, Paul Cercueil wrote: > > > > When the driver probes, the PWM pin is auto

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-25 Thread Uwe Kleine-König
On Wed, May 22, 2019 at 06:34:28PM +0200, Paul Cercueil wrote: > When the driver probes, the PWM pin is automatically configured to its > default state, which should be the "pwm" function. However, at this > point we don't know the actual level of the pin, which may be active or > inactive. As a re

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Linus Walleij
On Fri, Jun 21, 2019 at 3:56 PM Thierry Reding wrote: > I'm not sure this would actually work because I think the way that > pinctrl handles states both "init" and "idle" would be the same pointer > values and therefore pinctrl_init_done() would think the driver didn't > change away from the "ini

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Paul Cercueil
Le lun. 24 juin 2019 à 17:46, Daniel Thompson a écrit : On Mon, Jun 24, 2019 at 04:31:57PM +0200, Paul Cercueil wrote: Le lun. 24 juin 2019 à 13:28, Daniel Thompson a écrit : > On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > > On Fri, Jun 21, 2019 at 01:41:45PM +

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Daniel Thompson
On Mon, Jun 24, 2019 at 04:31:57PM +0200, Paul Cercueil wrote: > > > Le lun. 24 juin 2019 à 13:28, Daniel Thompson a > écrit : > > On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > > > On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > > > > On 22/05/2019 17:34,

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Paul Cercueil
Le ven. 21 juin 2019 à 15:56, Thierry Reding a écrit : On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: On 22/05/2019 17:34, Paul Cercueil wrote: > When the driver probes, the PWM pin is automatically configured to its > default state, which should be the "pwm" function

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Paul Cercueil
Le lun. 24 juin 2019 à 13:28, Daniel Thompson a écrit : On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > On 22/05/2019 17:34, Paul Cercueil wrote: > > When the driver probes, the PWM pin is automatically co

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-24 Thread Daniel Thompson
On Fri, Jun 21, 2019 at 03:56:08PM +0200, Thierry Reding wrote: > On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > > On 22/05/2019 17:34, Paul Cercueil wrote: > > > When the driver probes, the PWM pin is automatically configured to its > > > default state, which should be the "pwm

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-21 Thread Thierry Reding
On Fri, Jun 21, 2019 at 01:41:45PM +0100, Daniel Thompson wrote: > On 22/05/2019 17:34, Paul Cercueil wrote: > > When the driver probes, the PWM pin is automatically configured to its > > default state, which should be the "pwm" function. > > At which point in the probe... and by who? The driver

Re: [PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-06-21 Thread Daniel Thompson
On 22/05/2019 17:34, Paul Cercueil wrote: When the driver probes, the PWM pin is automatically configured to its default state, which should be the "pwm" function. At which point in the probe... and by who? However, at this point we don't know the actual level of the pin, which may be active

[PATCH] backlight: pwm_bl: Set pin to sleep state when powered down

2019-05-22 Thread Paul Cercueil
When the driver probes, the PWM pin is automatically configured to its default state, which should be the "pwm" function. However, at this point we don't know the actual level of the pin, which may be active or inactive. As a result, if the driver probes without enabling the backlight, the PWM pin