Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-23 Thread Lee Jones
On Wed, 18 Jul 2018, Daniel Thompson wrote: > On Wed, Jul 18, 2018 at 04:55:44PM +0100, Lee Jones wrote: > > On Wed, 18 Jul 2018, Daniel Thompson wrote: > > > > > On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote: > > > > > > > > No, then we are back to the initial issue of num_steps > >

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote: > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > > > On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > > > > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > > > > > >

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
On Wed, 2018-07-18 at 14:08 +0100, Lee Jones wrote: > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote: > > > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > > > > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > > > > > > >

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > Currently, if the DT does not define num-interpolated-steps then > > num_steps is undefined and the interpolation code will deploy > > randomly. > > Fix this. > > > > Fixes: 573fe6d1c25c ("back

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Daniel Thompson
On Wed, Jul 18, 2018 at 04:55:44PM +0100, Lee Jones wrote: > On Wed, 18 Jul 2018, Daniel Thompson wrote: > > > On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote: > > > > > > > No, then we are back to the initial issue of num_steps > > > > > > > potentially not > > > > > > > being initialis

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Lee Jones
On Wed, 18 Jul 2018, Daniel Thompson wrote: > On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote: > > > > > > No, then we are back to the initial issue of num_steps > > > > > > potentially not > > > > > > being initialised. We really want both of_property_read_u32() to > > > > > > succeed A

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Daniel Thompson
On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote: > > > > > No, then we are back to the initial issue of num_steps > > > > > potentially not > > > > > being initialised. We really want both of_property_read_u32() to > > > > > succeed AND num_steps to actually be set. > > > > > > > > I als

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Lee Jones
On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote: > > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > > > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > > > > > On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > > > > > On M

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Daniel Thompson
On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > > > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > > > > > Currently, if the DT does not define num-interpolated-steps then > > >

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Lee Jones
On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > > > Currently, if the DT does not define num-interpolated-steps then > > > num_steps is undefined and the interpolation code will deploy > > > ra

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Daniel Thompson
On Wed, Jul 18, 2018 at 09:09:13AM +0100, Lee Jones wrote: > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > Currently, if the DT does not define num-interpolated-steps then > > num_steps is undefined and the interpolation code will deploy randomly. > > Fix this. > > > > Fixes: 573fe6d1c25c ("b

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Lee Jones
On Wed, 18 Jul 2018, Lee Jones wrote: > On Mon, 16 Jul 2018, Daniel Thompson wrote: > > > Currently, if the DT does not define num-interpolated-steps then > > num_steps is undefined and the interpolation code will deploy randomly. > > Fix this. > > > > Fixes: 573fe6d1c25c ("backlight: pwm_bl: Li

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-18 Thread Lee Jones
On Mon, 16 Jul 2018, Daniel Thompson wrote: > Currently, if the DT does not define num-interpolated-steps then > num_steps is undefined and the interpolation code will deploy randomly. > Fix this. > > Fixes: 573fe6d1c25c ("backlight: pwm_bl: Linear interpolation between > brightness-levels") > Re

[PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-16 Thread Daniel Thompson
Currently, if the DT does not define num-interpolated-steps then num_steps is undefined and the interpolation code will deploy randomly. Fix this. Fixes: 573fe6d1c25c ("backlight: pwm_bl: Linear interpolation between brightness-levels") Reported-by: Marcel Ziswiler Signed-off-by: Daniel Thompson