Re: [PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread kbuild test robot
Hi Linus, I love your patch! Perhaps something to improve: [auto build test WARNING on backlight/for-backlight-next] [also build test WARNING on arm-soc/for-next spi/for-next tegra-drm/drm/tegra/for-next v5.7-rc3 next-20200428] [if your patch is applied to the wrong git tree, please drop us a no

Re: [PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
On Wed, Apr 29, 2020 at 1:33 PM Daniel Thompson wrote: > On Wed, Apr 29, 2020 at 10:26:31AM +0200, Linus Walleij wrote: > > - if (pdata != NULL) { > > - ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio, > > - GPIOF_DIR_OUT | (!pdata->reset_inver

Re: [PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Daniel Thompson
On Wed, Apr 29, 2020 at 10:26:31AM +0200, Linus Walleij wrote: > This converts the lms283gf05 backlight driver to use GPIO > descriptors and switches the single PXA Palm Z2 device > over to defining these. > > Since the platform data was only used to convey GPIO > information we can delete the pla

[PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
This converts the lms283gf05 backlight driver to use GPIO descriptors and switches the single PXA Palm Z2 device over to defining these. Since the platform data was only used to convey GPIO information we can delete the platform data header. Notice that we define the proper active low semantics i