Re: [PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-10-09 Thread Lee Jones
On Fri, 21 Sep 2018, Nathan Chancellor wrote: > Clang warns that the address of a pointer will always evaluated as true > in a boolean context. > > drivers/video/backlight/lm3639_bl.c:403:14: warning: address of > 'pchip->cdev_torch' will always evaluate to 'true' > [-Wpointer-bool-conversion] >

Re: [PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-09-26 Thread Daniel Thompson
On Mon, Sep 24, 2018 at 02:41:04PM -0700, Nick Desaulniers wrote: > On Fri, Sep 21, 2018 at 4:10 PM Nathan Chancellor > wrote: > > > > On Fri, Sep 21, 2018 at 03:48:50PM -0700, Nick Desaulniers wrote: > > > On Fri, Sep 21, 2018 at 1:23 PM Nathan Chancellor > > > wrote: > > > > > > > > Clang warns

Re: [PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-09-25 Thread Nick Desaulniers
On Fri, Sep 21, 2018 at 4:10 PM Nathan Chancellor wrote: > > On Fri, Sep 21, 2018 at 03:48:50PM -0700, Nick Desaulniers wrote: > > On Fri, Sep 21, 2018 at 1:23 PM Nathan Chancellor > > wrote: > > > > > > Clang warns that the address of a pointer will always evaluated as true > > > in a boolean co

[PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-09-23 Thread Nathan Chancellor
Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/video/backlight/lm3639_bl.c:403:14: warning: address of 'pchip->cdev_torch' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pchip->cdev_torch) ~~ ~~~^

Re: [PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-09-23 Thread Nathan Chancellor
On Fri, Sep 21, 2018 at 03:48:50PM -0700, Nick Desaulniers wrote: > On Fri, Sep 21, 2018 at 1:23 PM Nathan Chancellor > wrote: > > > > Clang warns that the address of a pointer will always evaluated as true > > in a boolean context. > > > > drivers/video/backlight/lm3639_bl.c:403:14: warning: addr

Re: [PATCH] backlight: lm3639: Unconditionally call led_classdev_unregister

2018-09-23 Thread Nick Desaulniers
On Fri, Sep 21, 2018 at 1:23 PM Nathan Chancellor wrote: > > Clang warns that the address of a pointer will always evaluated as true > in a boolean context. > > drivers/video/backlight/lm3639_bl.c:403:14: warning: address of > 'pchip->cdev_torch' will always evaluate to 'true' > [-Wpointer-bool-co